feat: bring back ios-simulator support #3278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okwasniewski
force-pushed
the
feat/ios-simulators
branch
from
0192f94
to
dab5c06
Compare
okwasniewski
commented
Apr 12, 2024
| @@ -414,6 +414,11 @@ function exampleProjectDefaults() | |||
| "-framework UIKit", | |||
| "-weak_framework Metal", | |||
| } | |||
| xcodecopyresources { | |||
| { "shaders/metal", { | |||
| os.matchfiles(path.join(BGFX_DIR, "examples/runtime/shaders/metal/**.bin")) | |||
There was a problem hiding this comment.
This fixes crashing examples
okwasniewski
force-pushed
the
feat/ios-simulators
branch
from
dab5c06
to
a798b84
Compare
okwasniewski
commented
Apr 12, 2024
| @@ -215,6 +216,14 @@ ios-arm64-release: .build/projects/gmake-ios-arm64 ## Build - iOS ARM64 Release | |||
| $(MAKE) -R -C .build/projects/gmake-ios-arm64 config=release | |||
| ios-arm64: ios-arm64-debug ios-arm64-release ## Build - iOS ARM64 Debug and Release | |||
|
|
|||
| .build/projects/gmake-ios-simulator: | |||
There was a problem hiding this comment.
I'm reintroducing only ios-simulator (64 bit) support as 32-bit simulators were discontinued.
iOS 10, which was released in 2016, was the last version of iOS to run 32-bit apps. As of iOS 11, all 32-bit apps installed on device will not launch.
Source: https://developer.apple.com/news/upcoming-requirements/?id=06062022a
okwasniewski
force-pushed
the
feat/ios-simulators
branch
from
a798b84
to
09c5e41
Compare
This reverts commit 8cb7445.
okwasniewski
force-pushed
the
feat/ios-simulators
branch
from
09c5e41
to
2ff9a61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces ios/tvos simulator support to bgfx. It will allow developers to develop and extend the framework easily.
Corresponding PR to
bx: bkaradzic/bx#322It should fix this issue: #3239
Test plan
Generate test projects using GENie (I've used the latest version from main):
iOS:
~/GENie/bin/darwin/genie --with-combined-examples --xcode=ios --gcc=ios-simulator xcode15tvOS:
~/GENie/bin/darwin/genie --with-combined-examples --xcode=tvos --gcc=tvos-simulator xcode15Screenshots
Note: I've tested everything on M1 Macbook Pro (Apple Silicon)