Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 16 actions are deprecated #1

Open
sjstark opened this issue Mar 25, 2024 · 4 comments
Open

Node 16 actions are deprecated #1

sjstark opened this issue Mar 25, 2024 · 4 comments

Comments

@sjstark
Copy link
Member

sjstark commented Mar 25, 2024

Getting this annotated warning

[Execute Order Processor (subscription)](https://github.com/BKWLD/clifbar.com/actions/runs/8426321661/job/23074385254)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
@sjstark
Copy link
Member Author

sjstark commented Mar 25, 2024

I'm not 100% sure on this, but our .nvmrc with 16 could be an issue?
https://github.com/BKWLD/cloak-actions/blob/main/install/action.yml#L11-L14

@weotch
Copy link
Member

weotch commented Mar 26, 2024

I think the issue is that some actions that we use (actions/checkout@v3, actions/setup-node@v3, actions/cache@v3) need to be updated to newer, Node 20+ versions.

@sjstark
Copy link
Member Author

sjstark commented Mar 27, 2024

Gotcha, so we should just update those to their @v4 versions

@sjstark
Copy link
Member Author

sjstark commented Mar 27, 2024

Not sure the best way to test, but I imagine this PR is what we're looking at doing: #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants