Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel 5.4 support #6

Closed
weotch opened this issue Feb 9, 2017 · 13 comments
Closed

Add Laravel 5.4 support #6

weotch opened this issue Feb 9, 2017 · 13 comments

Comments

@weotch
Copy link
Member

weotch commented Feb 9, 2017

Trust to the ConvertEmptyStringsToNull middleware to converty empty string to null rather than that PHP Library method.

@jonathan-bird
Copy link

+1 - when can we expect a 5.4 release?

@weotch
Copy link
Member Author

weotch commented Mar 16, 2017

I hope to in the next couple of weeks. Though I could see bumping it up if there is a lot of demand for it.

@jonathan-bird
Copy link

It'd definitely be great, I want to use it on a project that's due in a couple weeks.

@weotch weotch mentioned this issue Mar 17, 2017
@symfonycoda
Copy link

This looks awesome. I'll give it a go when the 5.4 version is up. Unfortunately I don't have time to contribute with code, but i m happy to help with trying it out and giving feedback/finding errors if that helps?

@weotch
Copy link
Member Author

weotch commented Mar 20, 2017

That would be great, thanks for the offer. It's looking good for me to break ground on this feature this week.

Btw, my first step will be to add integration tests for the current version and then see what breaks when updating the Laravel version constaint.

@jonathan-bird
Copy link

Very excited!

@weotch weotch changed the title L5.4 Add L5.4 support Mar 22, 2017
@weotch weotch changed the title Add L5.4 support Add Laravel 5.4 support Mar 22, 2017
@Solinx
Copy link

Solinx commented Apr 2, 2017

+1

1 similar comment
@eminos
Copy link

eminos commented Apr 3, 2017

+1

@weotch
Copy link
Member Author

weotch commented Apr 3, 2017

To update this thread, we've finished the integration test phase, next step will be adding 5.3 support and then immediately on to 5.4.

@eminos
Copy link

eminos commented Apr 3, 2017

@weotch I hate asking, but do you have an idea of when 5.4 compatibility might be ready? Days, weeks months? I'm starting a new website project this week and would love to try using Decoy for it, but using the old L5.2 for it just to be able to use Decoy feels a bit backwards :)

@weotch
Copy link
Member Author

weotch commented Apr 3, 2017

I would say within 2 weeks from now, ideally this week.

@weotch
Copy link
Member Author

weotch commented Apr 10, 2017

@weotch weotch closed this as completed Apr 10, 2017
@jonathan-bird
Copy link

jonathan-bird commented Apr 10, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants