Skip to content
This repository has been archived by the owner on Aug 27, 2019. It is now read-only.

Modularize the code in the src folder #26

Open
gtanner opened this issue Jul 5, 2012 · 3 comments
Open

Modularize the code in the src folder #26

gtanner opened this issue Jul 5, 2012 · 3 comments
Labels
Milestone

Comments

@gtanner
Copy link
Contributor

gtanner commented Jul 5, 2012

Currently we only have 2 files:

https://github.com/blackberry/Alice/blob/master/js/src/alice.core.js
and
https://github.com/blackberry/Alice/blob/master/js/src/alice.plugins.cheshire.js

We should further break these down and reorganize the src folder.

I would expect something like the bounce plugin:
https://github.com/blackberry/Alice/blob/master/js/src/alice.plugins.cheshire.js#L279-310

To be in a file called bounce.js and have it included into the final build result automatically.

This will require changes to building and such to include all the files together in the proper order.

@ldhasson
Copy link
Contributor

ldhasson commented Jul 5, 2012

I am not sure that we need to cut off derived effects each into their own file do you? I am OK to separate the derived effects from the master effect though.

@gtanner
Copy link
Contributor Author

gtanner commented Jul 5, 2012

I would think so. I like to have files serve once purpose to limit scope of what you are looking at.

I would hope that this helps narrow down a better plugin format for alice to start being able to allow 3rd party animations to plug into the engine.

@ldhasson
Copy link
Contributor

ldhasson commented Jul 5, 2012

Hmmm... so maybe, that's it... Sub-effects (or derived effects) are technically not plugins... They are shortcuts over a master effect. Maybe that's the confusion? There is no format specifically or best practices, except that it should be (1) a minimal subset of the parameters used for the master effect, and (2) a flat list of parameters.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants