Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AtatCmd parameters as consts #88

Closed
MathiasKoch opened this issue May 5, 2021 · 0 comments · Fixed by #91
Closed

AtatCmd parameters as consts #88

MathiasKoch opened this issue May 5, 2021 · 0 comments · Fixed by #91
Labels
atat_derive Issues related to the atat_derive crate of the workspace atat Issues related to the atat crate of the workspace enhancement New feature or request good first issue Good for newcomers

Comments

@MathiasKoch
Copy link
Member

The below parameters of atatCmd could be written as eg const CAN_ABORT: bool = false;

    /// Whether or not this command can be aborted.
    fn can_abort(&self) -> bool {
        false
    }

    /// The max timeout in milliseconds.
    fn max_timeout_ms(&self) -> u32 {
        1000
    }

    /// Force the ingress manager into receive state immediately after sending
    /// the command.
    fn force_receive_state(&self) -> bool {
        false
    }

    /// Force client to look for a response.
    /// Empty slice is then passed to parse by client.
    /// Implemented to enhance expandability fo ATAT
    fn expects_response_code(&self) -> bool {
        true
    }
@MathiasKoch MathiasKoch added enhancement New feature or request good first issue Good for newcomers atat Issues related to the atat crate of the workspace atat_derive Issues related to the atat_derive crate of the workspace labels May 5, 2021
@MathiasKoch MathiasKoch changed the title atatCmd parameters as consts AtatCmd parameters as consts May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atat_derive Issues related to the atat_derive crate of the workspace atat Issues related to the atat crate of the workspace enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant