Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better tests for portscan module #1516

Closed
5 tasks done
TheTechromancer opened this issue Jun 28, 2024 · 1 comment
Closed
5 tasks done

Better tests for portscan module #1516

TheTechromancer opened this issue Jun 28, 2024 · 1 comment
Assignees
@TheTechromancer
Labels
enhancement New feature or request
Milestone
BBOT 2.0.0 - cris...

Comments

@TheTechromancer
Copy link
Collaborator

TheTechromancer commented Jun 28, 2024 •
edited
Loading

In the portscan module, we should make sure that:

  • Targets are sorted by length so that bigger IP_RANGE events are added first
  • Individual IP_ADDRESS events are not being scanned if their parent IP_RANGE has been scanned already
  • Hostnames sharing the same IP should still raise OPEN_TCP_PORT events, even if the IP has been scanned already
  • Discovery chains are correct regardless of whether the source event is an IP_ADDRESS, IP_RANGE, or DNS_NAME
  • Test ping mode

Thanks to @amiremami for discovering some bugs in the new portscan module.
@TheTechromancer TheTechromancer added the enhancement New feature or request label Jun 28, 2024
@TheTechromancer TheTechromancer self-assigned this Jun 28, 2024
@TheTechromancer TheTechromancer mentioned this issue Jun 28, 2024
Merged
@TheTechromancer
Copy link
Collaborator Author

Added in #1517.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheTechromancer TheTechromancer

Labels
enhancement New feature or request
Projects
None yet
Milestone
BBOT 2.0.0 - crispy_diane
Development

No branches or pull requests
1 participant
@TheTechromancer