Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the js-test-driver json bug that often prevents you seeing your errors #52

Closed
andy-berry-dev opened this issue Oct 7, 2013 · 5 comments
Closed

fix the js-test-driver json bug that often prevents you seeing your errors #52

andy-berry-dev opened this issue Oct 7, 2013 · 5 comments
Labels
enhancement js-framework size 3 testing
Milestone
Sprint 6

Comments

@andy-berry-dev
Copy link
Member

originally raised by @thanhc - see https://github.com/BladeRunnerJS/brjs-private/issues/199 for the original issue

"This is the issue when the JSON is corrupt and as a result you get a js test driver error instead of what test failed"
@andy-berry-dev andy-berry-dev mentioned this issue Oct 15, 2013
Closed
@andy-berry-dev
Copy link
Member Author

This is ready for test as soon as the build is using the GitHub version - see comment on #107

@sospirited
Copy link
Member

@andyberry88 Do we know of an easy way that this could be reproduced? (prior to any fixes)

@andy-berry-dev
Copy link
Member Author

No idea, one for @dchambers.

@andy-berry-dev
Copy link
Member Author

@sospirited can we close this and keep an eye on it?

@sospirited
Copy link
Member

@andyberry88 makes sense. Haven't been able to find someone who can provide steps to reproduce. Happy to open again if we see this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement js-framework size 3 testing
Projects
None yet
Milestone
Sprint 6
Development

No branches or pull requests
2 participants
@andy-berry-dev @sospirited