-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make plural after a number lower case #82
Conversation
OK, we should be good now - first error was for spaces/tabs , the second was me adding a test into the test.js Thanks |
How about just inverting the current checks to do |
I tried that, unfortunately it doesn't work with things like "Work Order2" and "SoundFX2" |
1 similar comment
Sorry, I'm an idiot! It does work - Corrected it now :) |
1 similar comment
1 similar comment
OK, sorted everything out now ... hopefully! |
@@ -49,7 +49,10 @@ | |||
// Tokens are an exact match. | |||
if (word === token) return token; | |||
|
|||
// Upper cased words. E.g. "HELLO". | |||
// Lower cased words. E.g. "hello". | |||
if (word === word.toLowerCase()) return token.toLowerCase(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Is it possible to remove the title case check now though and fallback to it by default if neither of these cases match? No need to check if that should be the default now anyhow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we did that things like soundFX, oDonald etc would fail
Why is this not being merged? |
Pull request to support adding the 's' as lower case if ending in a numeric value.
Solves request #77
Thanks
Rob