Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak + App crash #2

Open
AKprisonER opened this issue Oct 24, 2017 · 9 comments
Open

Memory leak + App crash #2

AKprisonER opened this issue Oct 24, 2017 · 9 comments

Comments

@AKprisonER
Copy link

Well it happened on emulator and real device too

@blakelee
Copy link
Owner

blakelee commented Oct 24, 2017

I fixed the app crash. Not sure about the memory leak. I've seen the leak app pop up a few times but it hasn't actually reported any leaks for me.

@AKprisonER
Copy link
Author

i think its due to storage permissions it seems

@AKprisonER
Copy link
Author

AKprisonER commented Oct 25, 2017

capture
using canaryleak...it dosent show any leaks in its screen.
Its just keeps showing and memory dump occuring
hgf

@blakelee
Copy link
Owner

Did the new commit fix the crashes for you? Rc1 of lifecycle components broke support with rxlifecycle so rxlifecycle needs to be updated.

That's what's been happening with me. No leaks yet it still pops up. I think it's due to rxlifecycle.

@AKprisonER
Copy link
Author

AKprisonER commented Oct 25, 2017

Memory leak is happening due to FinalizerReference it seems

  1. Coinprofits.model
    2.Coinprofits,fragment

And finally,i came to a conclusion that kotlin is still not perfect for android apps

@blakelee
Copy link
Owner

Stack overflow seems to not have a lot of information about it. Since you said it's in a fragment I have an idea where to look.

The overview fragment doesn't have any separation. I need to restructure it to mvvm. Once it has some better architecture, maybe the issue will solve itself.

I'm pretty happy with using kotlin so far. Just takes a bit to get used to

@AKprisonER
Copy link
Author

How to add multi currency ?
As i am out of USD, like choose display currency from Euro or Krw or Inr

@blakelee
Copy link
Owner

I setup the db so that eventually I could add differing currencies. Coinmarketcap has api calls for different ones. However, the map api only allowed for usd. I'm not sure how I wanted to implement it. I was thinking of having usd be the base and having a multiplier for the other currencies

@AKprisonER
Copy link
Author

Any implementation of other currencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants