Fix issue when converting datetimes and pandas Timestamps in an expression #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrocklin okay with this? |
cpcloud
changed the title
| @@ -63,7 +64,7 @@ def _print_python(expr, leaves=None): | |||
|
|
|||
| @dispatch((datetime.datetime, datetime.date)) | |||
| def _print_python(expr, leaves=None): | |||
| return repr(expr), {'datetime': datetime} | |||
| return repr(expr), {'datetime': datetime, 'Timestamp': pd.Timestamp} | |||
There was a problem hiding this comment.
Are there cases where we intended to print python datetime objects that we actually end up printing Pandas Timestamps? If so is there an issue? Do we ever not assume that pandas is around?
There was a problem hiding this comment.
Are there cases where we intended to print python datetime objects that we actually end up printing Pandas Timestamps?
Not sure. FWIW, Timestamp is a subclass of datetime.datetime.
Do we ever not assume that pandas is around?
No, pandas is a hard dependency.
|
I'll add that one thing that's nice about pandas |
|
merging |
cpcloud
added a commit
that referenced
this pull request
May 26, 2015
Fix issue when converting datetimes and pandas Timestamps in an expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mrocklin