Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] Add Off functionality to unregister callbacks #5

Closed
rpedretti opened this issue Jul 17, 2018 · 3 comments
Closed

[Request] Add Off functionality to unregister callbacks #5

rpedretti opened this issue Jul 17, 2018 · 3 comments
Assignees
@galvesribeiro
Labels
enhancement New feature or request

Comments

@rpedretti
Copy link

It would be nice to have it in both Off("name", callback) and Off("name") to unregister all call-backs for "name"
@galvesribeiro galvesribeiro self-assigned this Jul 17, 2018
@galvesribeiro galvesribeiro added the enhancement New feature or request label Jul 17, 2018
@galvesribeiro
Copy link
Member

Thanks @rpedretti I'll look at it later tonight. Will keep you posted.

@rpedretti
Copy link
Author

Thanks! Its a great extension to Blazor! Great job!

@galvesribeiro galvesribeiro mentioned this issue Jul 19, 2018
Merged
galvesribeiro added a commit that referenced this issue Jul 19, 2018
@galvesribeiro
Merge pull request #7 from BlazorExtensions/fix-bug-6
078464d 
Fix serialization issues from #6
Implemented "Off()" functionality #5
Allow multiple "On()" registrations for the same method. #5
@galvesribeiro
Copy link
Member

galvesribeiro commented Jul 19, 2018 •
edited
Loading

Added with #7 and will be out on 0.1.3. Thanks for the request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galvesribeiro galvesribeiro

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rpedretti @galvesribeiro