Disallow use of console, alert, and debugger, part 2. #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add drop downs to the open dialog * pulled selector into a separate component * clean up * add the tests * style the open dialog * add test for files * address comments * clean up * updatee tests * clean up logs * subtract ... * test * and at symbol to the orgname * add at symbol * populate js doc description * simplify selection logic * revert the change * change properties to include name * fix the navigate path * clean up * simplify the navigate path * Clean github functions (bldrs-ai#672) * clean github functions * add unit tests * revert whitespace, check missed params in api handlers * revert whitespaces of content in api handler * few style chnages --------- Co-authored-by: Ron <rondoor124@gmail.com>
* Replace storybook with react-cosmos. Mostly working. * Replace storybook with react-cosmos. Mostly working. * yarn build: both serve and cosmos. Remove broken stories. * yarn build-cosmos: clean build before build. Obey NODE_ENV production or development settings. * cosmos.webpack.js: use root serving path for standalone local dev but under /sb for prod. * cosmos.webpack.js: more testing to put output under /sb in prod. * Remove debug logging * Remove HtmlPlugin from React Cosmos webpack config per random advice on internet. * Testing cosmos build locations. * Testing cosmos build locations 2.
…-ai#617) * feat: custom viewer api * subset list to dict * remove log statement * fix missing __getIFCViewerAPIMockSingleton * pickByID new implementation * fix: remove resetSelection guard to fix key down callback function lost state * fix: reset selection guard back to fix failing tests and call the from the call back func changed * subsets revisited * unhide all hidden elements * feature: ifc isolator component, incapsulates hide and isolate operations * fix: ids loaded from meshes to insure having visual props * fix: remove unused ifc classes imports * fix: get express ids from model mesh attributes for better performance * fix: reset reveal upon unhide * fix: turn off reveal on unhide all * feat: hide/unhide icons in nav tree for spatial structures and root aggregators * fix: failing unit tests * linter fixes * fix: reveal hidden elements material's depthTest * re-evaluate reveal subset if on when hiding again * fix: ifc viewer highlighter * remove unused imports * fix: disable hide icons on temp isolation mode * reflect isoaltor status to selected elements store * unit test for hide element by the tree icons * toggle hide icon e2e test * fix post processor * fix failing cadview tests * fix: placemarks broke the other post processing effects * fix: remove singleton post-processor * fix: space typo * fix: disable lint error * fix: maintain hidden elements when viewer changes * fix: align hide icons to right --------- Signed-off-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> Co-authored-by: Ibrahim Saad <ibrahim.saad@xbim.net> Co-authored-by: OlegMoshkovich <oleg.mosh@gmail.com> Co-authored-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com>
…ures for Dialog, About and fix ControlButton. (bldrs-ai#682) Signed-off-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com>
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pablo-mayrgundter
approved these changes
Mar 27, 2023
|
@pablo-mayrgundter The unit tests are failing from the |
I think eslint errors by default are fine but also the console output is permanently useful for fixtures. Are they suppressible like normal? If so just suppress the existing ones and we can do so going forward. If not remove. |
OlegMoshkovich
added a commit
to OlegMoshkovich/Share
that referenced
this pull request
Mar 31, 2023
* Disallow use of console logging, alerts, and debugging * Calling unimplemented methods should raise an exception * Allow console logging for logic that only occurs in development and testing * Allow console logging for CLI/build tooling * Remove unnecessary console logging * Convert console logging to debug statements * Fix path for utils import * File access dialog (bldrs-ai#640) * add drop downs to the open dialog * pulled selector into a separate component * clean up * add the tests * style the open dialog * add test for files * address comments * clean up * updatee tests * clean up logs * subtract ... * test * and at symbol to the orgname * add at symbol * populate js doc description * simplify selection logic * revert the change * change properties to include name * fix the navigate path * clean up * simplify the navigate path * Clean github functions (bldrs-ai#672) * clean github functions * add unit tests * revert whitespace, check missed params in api handlers * revert whitespaces of content in api handler * few style chnages --------- Co-authored-by: Ron <rondoor124@gmail.com> * Update severity levels for particular debug calls * Replace storybook with react-cosmos (bldrs-ai#609) * Replace storybook with react-cosmos. Mostly working. * Replace storybook with react-cosmos. Mostly working. * yarn build: both serve and cosmos. Remove broken stories. * yarn build-cosmos: clean build before build. Obey NODE_ENV production or development settings. * cosmos.webpack.js: use root serving path for standalone local dev but under /sb for prod. * cosmos.webpack.js: more testing to put output under /sb in prod. * Remove debug logging * Remove HtmlPlugin from React Cosmos webpack config per random advice on internet. * Testing cosmos build locations. * Testing cosmos build locations 2. * align rectangular button and change the order of notes (bldrs-ai#683) * VYZN: (feature) hide/unhide and temporary isolate IFC elements (bldrs-ai#617) * feat: custom viewer api * subset list to dict * remove log statement * fix missing __getIFCViewerAPIMockSingleton * pickByID new implementation * fix: remove resetSelection guard to fix key down callback function lost state * fix: reset selection guard back to fix failing tests and call the from the call back func changed * subsets revisited * unhide all hidden elements * feature: ifc isolator component, incapsulates hide and isolate operations * fix: ids loaded from meshes to insure having visual props * fix: remove unused ifc classes imports * fix: get express ids from model mesh attributes for better performance * fix: reset reveal upon unhide * fix: turn off reveal on unhide all * feat: hide/unhide icons in nav tree for spatial structures and root aggregators * fix: failing unit tests * linter fixes * fix: reveal hidden elements material's depthTest * re-evaluate reveal subset if on when hiding again * fix: ifc viewer highlighter * remove unused imports * fix: disable hide icons on temp isolation mode * reflect isoaltor status to selected elements store * unit test for hide element by the tree icons * toggle hide icon e2e test * fix post processor * fix failing cadview tests * fix: placemarks broke the other post processing effects * fix: remove singleton post-processor * fix: space typo * fix: disable lint error * fix: maintain hidden elements when viewer changes * fix: align hide icons to right --------- Signed-off-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> Co-authored-by: Ibrahim Saad <ibrahim.saad@xbim.net> Co-authored-by: OlegMoshkovich <oleg.mosh@gmail.com> Co-authored-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> * Upgrade packages. Fixup mui styling change to Dialog button. Add fixtures for Dialog, About and fix ControlButton. (bldrs-ai#682) Signed-off-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> * Suppress eslint violation per Pablo (bldrs-ai#688) * Remove no-op ESLint rule control --------- Signed-off-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> Co-authored-by: OlegMoshkovich <oleg.mosh@gmail.com> Co-authored-by: Ron <rondoor124@gmail.com> Co-authored-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> Co-authored-by: Ibrahim Saad <ibrahim.saad@xbim.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add ESLint rules that will loudly complain if one attempts to use console.*, alert(), or debugger;.
Repeat PR due to a bad merge.