New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace storybook with react-cosmos #609
Replace storybook with react-cosmos #609
Conversation
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This is building and running for me locally, but deploy preview fails with an MSW error. Not sure why it is being included tho, as it's not a dep of react-cosmos.. so maybe |
… or development settings.
… under /sb for prod.
Ok, ready for review! |
ping |
looking over it. |
Note they're 80% or so deletes. Storybook was a beast |
* Replace storybook with react-cosmos. Mostly working. * Replace storybook with react-cosmos. Mostly working. * yarn build: both serve and cosmos. Remove broken stories. * yarn build-cosmos: clean build before build. Obey NODE_ENV production or development settings. * cosmos.webpack.js: use root serving path for standalone local dev but under /sb for prod. * cosmos.webpack.js: more testing to put output under /sb in prod. * Remove debug logging * Remove HtmlPlugin from React Cosmos webpack config per random advice on internet. * Testing cosmos build locations. * Testing cosmos build locations 2.
* Disallow use of console logging, alerts, and debugging * Calling unimplemented methods should raise an exception * Allow console logging for logic that only occurs in development and testing * Allow console logging for CLI/build tooling * Remove unnecessary console logging * Convert console logging to debug statements * Fix path for utils import * File access dialog (#640) * add drop downs to the open dialog * pulled selector into a separate component * clean up * add the tests * style the open dialog * add test for files * address comments * clean up * updatee tests * clean up logs * subtract ... * test * and at symbol to the orgname * add at symbol * populate js doc description * simplify selection logic * revert the change * change properties to include name * fix the navigate path * clean up * simplify the navigate path * Clean github functions (#672) * clean github functions * add unit tests * revert whitespace, check missed params in api handlers * revert whitespaces of content in api handler * few style chnages --------- Co-authored-by: Ron <rondoor124@gmail.com> * Update severity levels for particular debug calls * Replace storybook with react-cosmos (#609) * Replace storybook with react-cosmos. Mostly working. * Replace storybook with react-cosmos. Mostly working. * yarn build: both serve and cosmos. Remove broken stories. * yarn build-cosmos: clean build before build. Obey NODE_ENV production or development settings. * cosmos.webpack.js: use root serving path for standalone local dev but under /sb for prod. * cosmos.webpack.js: more testing to put output under /sb in prod. * Remove debug logging * Remove HtmlPlugin from React Cosmos webpack config per random advice on internet. * Testing cosmos build locations. * Testing cosmos build locations 2. * align rectangular button and change the order of notes (#683) * VYZN: (feature) hide/unhide and temporary isolate IFC elements (#617) * feat: custom viewer api * subset list to dict * remove log statement * fix missing __getIFCViewerAPIMockSingleton * pickByID new implementation * fix: remove resetSelection guard to fix key down callback function lost state * fix: reset selection guard back to fix failing tests and call the from the call back func changed * subsets revisited * unhide all hidden elements * feature: ifc isolator component, incapsulates hide and isolate operations * fix: ids loaded from meshes to insure having visual props * fix: remove unused ifc classes imports * fix: get express ids from model mesh attributes for better performance * fix: reset reveal upon unhide * fix: turn off reveal on unhide all * feat: hide/unhide icons in nav tree for spatial structures and root aggregators * fix: failing unit tests * linter fixes * fix: reveal hidden elements material's depthTest * re-evaluate reveal subset if on when hiding again * fix: ifc viewer highlighter * remove unused imports * fix: disable hide icons on temp isolation mode * reflect isoaltor status to selected elements store * unit test for hide element by the tree icons * toggle hide icon e2e test * fix post processor * fix failing cadview tests * fix: placemarks broke the other post processing effects * fix: remove singleton post-processor * fix: space typo * fix: disable lint error * fix: maintain hidden elements when viewer changes * fix: align hide icons to right --------- Signed-off-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> Co-authored-by: Ibrahim Saad <ibrahim.saad@xbim.net> Co-authored-by: OlegMoshkovich <oleg.mosh@gmail.com> Co-authored-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> * Upgrade packages. Fixup mui styling change to Dialog button. Add fixtures for Dialog, About and fix ControlButton. (#682) Signed-off-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> * Suppress eslint violation per Pablo (#688) * Remove no-op ESLint rule control --------- Signed-off-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> Co-authored-by: OlegMoshkovich <oleg.mosh@gmail.com> Co-authored-by: Ron <rondoor124@gmail.com> Co-authored-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> Co-authored-by: Ibrahim Saad <ibrahim.saad@xbim.net>
* Disallow use of console logging, alerts, and debugging * Calling unimplemented methods should raise an exception * Allow console logging for logic that only occurs in development and testing * Allow console logging for CLI/build tooling * Remove unnecessary console logging * Convert console logging to debug statements * Fix path for utils import * File access dialog (bldrs-ai#640) * add drop downs to the open dialog * pulled selector into a separate component * clean up * add the tests * style the open dialog * add test for files * address comments * clean up * updatee tests * clean up logs * subtract ... * test * and at symbol to the orgname * add at symbol * populate js doc description * simplify selection logic * revert the change * change properties to include name * fix the navigate path * clean up * simplify the navigate path * Clean github functions (bldrs-ai#672) * clean github functions * add unit tests * revert whitespace, check missed params in api handlers * revert whitespaces of content in api handler * few style chnages --------- Co-authored-by: Ron <rondoor124@gmail.com> * Update severity levels for particular debug calls * Replace storybook with react-cosmos (bldrs-ai#609) * Replace storybook with react-cosmos. Mostly working. * Replace storybook with react-cosmos. Mostly working. * yarn build: both serve and cosmos. Remove broken stories. * yarn build-cosmos: clean build before build. Obey NODE_ENV production or development settings. * cosmos.webpack.js: use root serving path for standalone local dev but under /sb for prod. * cosmos.webpack.js: more testing to put output under /sb in prod. * Remove debug logging * Remove HtmlPlugin from React Cosmos webpack config per random advice on internet. * Testing cosmos build locations. * Testing cosmos build locations 2. * align rectangular button and change the order of notes (bldrs-ai#683) * VYZN: (feature) hide/unhide and temporary isolate IFC elements (bldrs-ai#617) * feat: custom viewer api * subset list to dict * remove log statement * fix missing __getIFCViewerAPIMockSingleton * pickByID new implementation * fix: remove resetSelection guard to fix key down callback function lost state * fix: reset selection guard back to fix failing tests and call the from the call back func changed * subsets revisited * unhide all hidden elements * feature: ifc isolator component, incapsulates hide and isolate operations * fix: ids loaded from meshes to insure having visual props * fix: remove unused ifc classes imports * fix: get express ids from model mesh attributes for better performance * fix: reset reveal upon unhide * fix: turn off reveal on unhide all * feat: hide/unhide icons in nav tree for spatial structures and root aggregators * fix: failing unit tests * linter fixes * fix: reveal hidden elements material's depthTest * re-evaluate reveal subset if on when hiding again * fix: ifc viewer highlighter * remove unused imports * fix: disable hide icons on temp isolation mode * reflect isoaltor status to selected elements store * unit test for hide element by the tree icons * toggle hide icon e2e test * fix post processor * fix failing cadview tests * fix: placemarks broke the other post processing effects * fix: remove singleton post-processor * fix: space typo * fix: disable lint error * fix: maintain hidden elements when viewer changes * fix: align hide icons to right --------- Signed-off-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> Co-authored-by: Ibrahim Saad <ibrahim.saad@xbim.net> Co-authored-by: OlegMoshkovich <oleg.mosh@gmail.com> Co-authored-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> * Upgrade packages. Fixup mui styling change to Dialog button. Add fixtures for Dialog, About and fix ControlButton. (bldrs-ai#682) Signed-off-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> * Suppress eslint violation per Pablo (bldrs-ai#688) * Remove no-op ESLint rule control --------- Signed-off-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> Co-authored-by: OlegMoshkovich <oleg.mosh@gmail.com> Co-authored-by: Ron <rondoor124@gmail.com> Co-authored-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com> Co-authored-by: Ibrahim Saad <ibrahim.saad@xbim.net>
Storybook has been pretty broken for awhile. It's very complex to configure and tons of out-of-date deps. react-cosmos seems to be pretty good so far, though it does lack theme support. We weren't using that with SB tho.
I've replaced it with https://reactcosmos.org/ and converted a few components overs. For files to be included in the book, add a harness with the suffix ".fixture.jsx" and they'll be found and included turing
yarn build-cosmos
which is now also part of the defaultyarn build
steps.Demo:
https://deploy-preview-609--bldrs-share.netlify.app/cosmos/
This serves with webpack5 too, so this removes webpack4 deps from our project.