You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
"Allow group selection resize" functionality does not calls onResize() when iterating through app.graph._nodes and causing nodes to incorrectly resized if there's multiline textbox widget.
#16
Closed
Trung0246 opened this issue
Nov 27, 2023
· 3 comments
It should call onResize instead of direct assignment.
To Reproduce
Steps to reproduce the behavior:
Install Anything Everywhere extension.
Install any extension that have multiline box display (I'll take my extension Beautify node).
Create a Anything Everywhere? node and Display Any node on the workflow
Attempt to change mode to anything except the same one.
Ensure that the Beautify node are selected and are actually being used in the extension and must display some information.
Click Queue Prompt
Expected behavior onResize callback should be called for Beautify node. But in this case it is not.
Desktop (please complete the following information):
OS: Windows
Browser: Firefox
Additional context
I'm trying to develop my nodes and after a couple of days figuring out why the node keep resizing unexpectedly I finally found the root cause which is that problematic line.
The text was updated successfully, but these errors were encountered:
Thanks for reporting. I might remove it entirely since I'm not sure how usedful it really is and it is pretty hacky diue to the nature of getting the selected nodes.
I removed the feature since it was hacky, unstable and causing issues with other extrensions.
We might revisit this one later. If you want this feature please select it from a previous version and copy it to ComfyUI/we/extensions all our extensions are standalone and can be dropped in that folder. ❤️ thank you for understanding.
Describe the bug
Especially for this specific line:
https://github.com/failfa-st/failfast-comfyui-extensions/blob/b67e161b434e92a36a0d42871a455bf1ff60e6d7/extensions/nodes.js#L57
It should call
onResize
instead of direct assignment.To Reproduce
Steps to reproduce the behavior:
Anything Everywhere
extension.Beautify
node).Anything Everywhere?
node andDisplay Any
node on the workflowmode
to anything except the same one.Beautify
node are selected and are actually being used in the extension and must display some information.Queue Prompt
Expected behavior
onResize
callback should be called forBeautify
node. But in this case it is not.Desktop (please complete the following information):
Additional context
I'm trying to develop my nodes and after a couple of days figuring out why the node keep resizing unexpectedly I finally found the root cause which is that problematic line.
The text was updated successfully, but these errors were encountered: