Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Allow group selection resize" functionality does not calls onResize() when iterating through app.graph._nodes and causing nodes to incorrectly resized if there's multiline textbox widget. #16

Closed
Trung0246 opened this issue Nov 27, 2023 · 3 comments

Comments

@Trung0246
Copy link

Describe the bug
Especially for this specific line:

https://github.com/failfa-st/failfast-comfyui-extensions/blob/b67e161b434e92a36a0d42871a455bf1ff60e6d7/extensions/nodes.js#L57

It should call onResize instead of direct assignment.

To Reproduce
Steps to reproduce the behavior:

  1. Install Anything Everywhere extension.
  2. Install any extension that have multiline box display (I'll take my extension Beautify node).
  3. Create a Anything Everywhere? node and Display Any node on the workflow
  4. Attempt to change mode to anything except the same one.
  5. Ensure that the Beautify node are selected and are actually being used in the extension and must display some information.
  6. Click Queue Prompt

Expected behavior
onResize callback should be called for Beautify node. But in this case it is not.

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Firefox

Additional context
I'm trying to develop my nodes and after a couple of days figuring out why the node keep resizing unexpectedly I finally found the root cause which is that problematic line.

@pixelass
Copy link
Member

Thanks for reporting. I might remove it entirely since I'm not sure how usedful it really is and it is pretty hacky diue to the nature of getting the selected nodes.

@DrJKL
Copy link

DrJKL commented Apr 18, 2024

I'd like to be able to bulk resize multiline text nodes.

@pixelass
Copy link
Member

pixelass commented May 9, 2024

I removed the feature since it was hacky, unstable and causing issues with other extrensions.
We might revisit this one later. If you want this feature please select it from a previous version and copy it to ComfyUI/we/extensions all our extensions are standalone and can be dropped in that folder. ❤️ thank you for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants