Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for mediaMatch in DomWatcher #235

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add support for mediaMatch in DomWatcher #235

wants to merge 4 commits into from

Conversation

angusm
Copy link
Member

@angusm angusm commented Apr 27, 2022

Hi Scott,

A change that adds some extra typing but mainly adds support for passing the result of a window.matchMedia() call to DomWatcher to listen for events.

@angusm angusm requested a review from uxder April 27, 2022 02:01
uxder
uxder reviewed Apr 27, 2022
View reviewed changes
Copy link
Member

@uxder uxder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't think about this. We can just listen to the change event with this. Nice.

I think this is nice but can you add some quick examples to the doc.

uxder
uxder approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@uxder uxder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. ty!

I think you'll need to squash merge this with the release please style commit messages to auto release it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uxder uxder uxder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angusm @uxder @amacdonald-google