Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[legacy-framework] Fix global CLI on canary by dynamically require server package #1265

Merged
merged 1 commit into from
Oct 6, 2020
Merged

[legacy-framework] Fix global CLI on canary by dynamically require server package #1265

merged 1 commit into from
Oct 6, 2020

Conversation

flybayer
Copy link
Member

@flybayer flybayer commented Oct 6, 2020

What are the changes and their implications?

This fixes an issue on canary where react-dom can't be found when using blitz cli.

@flybayer flybayer requested a review from aem as a code owner October 6, 2020 22:42
@blitzjs-bot blitzjs-bot bot added this to In Review in Dashboard Oct 6, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2020

Size Change: 0 B

Total Size: 188 kB

ℹ️ View Unchanged
Filename Size Change
packages/blitz/dist/cli.js 15.7 kB 0 B
packages/blitz/dist/index.js 245 B 0 B
packages/config/dist/config.cjs.development.js 1.35 kB 0 B
packages/config/dist/config.cjs.production.min.js 916 B 0 B
packages/config/dist/config.esm.js 1.28 kB 0 B
packages/config/dist/index.js 143 B 0 B
packages/core/dist/core.cjs.development.js 12.3 kB 0 B
packages/core/dist/core.cjs.production.min.js 6.75 kB 0 B
packages/core/dist/core.esm.js 12 kB 0 B
packages/core/dist/index.js 141 B 0 B
packages/display/dist/display.cjs.development.js 1.41 kB 0 B
packages/display/dist/display.cjs.production.min.js 802 B 0 B
packages/display/dist/display.esm.js 1.3 kB 0 B
packages/display/dist/index.js 144 B 0 B
packages/file-pipeline/dist/file-pipeline.cjs.development.js 5.9 kB 0 B
packages/file-pipeline/dist/file-pipeline.cjs.production.min.js 3.02 kB 0 B
packages/file-pipeline/dist/file-pipeline.esm.js 5.76 kB 0 B
packages/file-pipeline/dist/index.js 147 B 0 B
packages/generator/dist/generator.cjs.development.js 15.2 kB 0 B
packages/generator/dist/generator.cjs.production.min.js 9.29 kB 0 B
packages/generator/dist/generator.esm.js 14.9 kB 0 B
packages/generator/dist/index.js 145 B 0 B
packages/generator/dist/templates/app/babel.config.js 77 B 0 B
packages/generator/dist/templates/app/blitz.config.js 324 B 0 B
packages/generator/dist/templates/app/jest.config.js 662 B 0 B
packages/generator/dist/templates/app/test/__mocks__/fileMock.js 54 B 0 B
packages/installer/dist/index.js 145 B 0 B
packages/installer/dist/installer.cjs.development.js 7.71 kB 0 B
packages/installer/dist/installer.cjs.production.min.js 5.13 kB 0 B
packages/installer/dist/installer.esm.js 7.57 kB 0 B
packages/repl/dist/index.js 141 B 0 B
packages/repl/dist/repl.cjs.development.js 1.73 kB 0 B
packages/repl/dist/repl.cjs.production.min.js 1.02 kB 0 B
packages/repl/dist/repl.esm.js 1.61 kB 0 B
packages/server/dist/index.js 142 B 0 B
packages/server/dist/server.cjs.development.js 20.4 kB 0 B
packages/server/dist/server.cjs.production.min.js 11.8 kB 0 B
packages/server/dist/server.esm.js 20.5 kB 0 B

compressed-size-action

@flybayer flybayer changed the title Refactor to dynamically require server package from CLI Fix global CLI on canary by dynamically require server package Oct 6, 2020
@flybayer flybayer merged commit 37ce99a into canary Oct 6, 2020
Dashboard automation moved this from In Review to Done Oct 6, 2020
@flybayer flybayer deleted the fix-cc branch October 6, 2020 23:00
nahue added a commit to nahue/blitz that referenced this pull request Oct 7, 2020
@nahue
Merge branch 'canary' of github.com:blitz-js/blitz into nahuel-update…
2693830 
…-ink

* 'canary' of github.com:blitz-js/blitz: (78 commits)
  v0.24.1
  Fix page template to use useMutation (blitz-js#1269)
  update patch for release script (meta)
  v0.24.0
  Few improvements to log colors (blitz-js#1267)
  Fix global CLI on canary by dynamically require server package (blitz-js#1265)
  Promote Simon to L2 Maintainership (blitz-js#1264)
  v0.24.0-canary.4
  Revert "Prefix session cookies with app name (blitz-js#1229)"
  Add @sandulat as a contributor
  v0.24.0-canary.3
  Prefix session cookies with app name (blitz-js#1229)
  docs: add Dohxis as a contributor (blitz-js#1261)
  Add tests for add-dependency-executor (blitz-js#1259)
  Add back RouterContext and BlitzRouter which got lost in last canary release (blitz-js#1260)
  v0.24.0-canary.2
  docs: add Alucard17 as a contributor (blitz-js#1256)
  Changed `@blitzjs/core` to only export public API (blitz-js#1246)
  Fix Safari compatibility: shim requestIdleCallback (blitz-js#1247)
  Fix regression on canary of loss of Prisma error code (blitz-js#1254)
  ...
@dillondotzip dillondotzip changed the title Fix global CLI on canary by dynamically require server package [legacy-framework] Fix global CLI on canary by dynamically require server package Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aem aem Awaiting requested review from aem

Assignees
No one assigned
Labels
status/done
Projects
No open projects
Dashboard
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@flybayer