[legacy-framework] (newapp) Fix validateDOMNesting error from default home page #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<pre> cannot appear as a descendant of <p>
|
Sweet, thanks @aericson!! Looks good. @all-contributors add @aericson for code |
|
I've put up a pull request to add @aericson! 🎉 |
flybayer
changed the title
wanjuntham
pushed a commit
to wanjuntham/blitz
that referenced
this pull request
Oct 11, 2020
nahue
added a commit
to nahue/blitz
that referenced
this pull request
Oct 13, 2020
…-ink * 'canary' of github.com:blitz-js/blitz: docs: add alexnaiman as a contributor (blitz-js#1299) Fix circular dependencies in blitz core (blitz-js#1249) docs: add aaronfulkerson as a contributor (blitz-js#1295) Remove "--experimental" from "blitz db studio" (blitz-js#1272) Remove Simon Debbarma and Jack Clancy from L1 maintainers. (blitz-js#1290) Update @aericson as a contributor Add @Kosai106 as a contributor docs: add cajotafer as a contributor (blitz-js#1293) (newapp) Add yarn/npx to global install instructions in readme (blitz-js#1285) Fix to allow babel config modification in Recipes (blitz-js#1280) Fix all recipes to add their context providers above getLayout() (blitz-js#1279) docs: add aericson as a contributor (blitz-js#1292) (newapp) Fix validateDOMNesting error from default home page (blitz-js#1277) Fix `blitz generate model` to add fields to existing model instead of duplicating (blitz-js#1251) Fix to not run husky during new app creation (blitz-js#1270) Adds tests for useSession in core super tokens (blitz-js#1258)
ntgussoni
added a commit
to ntgussoni/blitz
that referenced
this pull request
Feb 7, 2021
* upstream/canary: (70 commits) docs: add alexnaiman as a contributor (blitz-js#1299) Fix circular dependencies in blitz core (blitz-js#1249) docs: add aaronfulkerson as a contributor (blitz-js#1295) Remove "--experimental" from "blitz db studio" (blitz-js#1272) Remove Simon Debbarma and Jack Clancy from L1 maintainers. (blitz-js#1290) Update @aericson as a contributor Add @Kosai106 as a contributor docs: add cajotafer as a contributor (blitz-js#1293) (newapp) Add yarn/npx to global install instructions in readme (blitz-js#1285) Fix to allow babel config modification in Recipes (blitz-js#1280) Fix all recipes to add their context providers above getLayout() (blitz-js#1279) docs: add aericson as a contributor (blitz-js#1292) (newapp) Fix validateDOMNesting error from default home page (blitz-js#1277) Fix `blitz generate model` to add fields to existing model instead of duplicating (blitz-js#1251) Fix to not run husky during new app creation (blitz-js#1270) Adds tests for useSession in core super tokens (blitz-js#1258) Add Alexandru Stratulat as L1 Maintainer (blitz-js#1271) v0.24.1 Fix page template to use useMutation (blitz-js#1269) update patch for release script (meta) ...
dillondotzip
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
<pre>cannot appear as a descendant of<p>. This will throw an error on a newly created project.I'm quite new to the codebase and didn't really know how to create a project using the updated template. I've only tested it by copying pasting the code to a project created with my global installed blitz CLI.
What are the changes and their implications?
Changed to remove the
<pre>from inside the<p>. I tried to keep the same design and to do that added an empty<div>and atext-align: center;to thepreselector.Here is a screenshot of the visually unchanged page:
Checklist