New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[legacy-framework] Allow using Route Manifest for Page.redirectAuthenticatedTo
#2243
Merged
flybayer
merged 4 commits into
canary
from
allow-routeurlobject-for-redirectAuthenticatedTo
May 17, 2021
Merged
[legacy-framework] Allow using Route Manifest for Page.redirectAuthenticatedTo
#2243
flybayer
merged 4 commits into
canary
from
allow-routeurlobject-for-redirectAuthenticatedTo
May 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @Skn0tt! Can you update our docs to include this feature? |
Skn0tt
added a commit
to blitz-js/blitzjs.com
that referenced
this pull request
May 14, 2021
flybayer
changed the title
Allow RouteUrlObject for redirectAuthenticatedTo
Allow using Route Manifest for May 17, 2021
Page.redirectAuthenticatedTo
Not at the moment, but I guess it should be possible. WDYT @flybayer? |
I think that should work. We just have to make sure we account for the fact that session is empty on first render. |
dillondotzip
changed the title
Allow using Route Manifest for
[legacy-framework] Allow using Route Manifest for Jul 7, 2022
Page.redirectAuthenticatedTo
Page.redirectAuthenticatedTo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes and their implications?
Allow devs to use Url Object for
redirectAuthenticatedTo
Bug Checklist
Feature Checklist