Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Add vanilla-extract recipe #2946

Merged
merged 5 commits into from
Nov 16, 2021
Merged

Conversation

JuanM04
Copy link

@JuanM04 JuanM04 commented Nov 12, 2021

Added vanilla-extract recipe

@beerose
Copy link
Contributor

beerose commented Nov 15, 2021

I think there's a bug with wrapping the config with createVanillaExtractPlugin — looks like the session is undefined, and there are multiple errors when accessing fields of the session context, e.g.: Cannot read property '$create' of undefined.

Here's also a related issue: blitz-js/legacy-framework#13, where wrapping the config causes the same problems.

@beerose beerose changed the title Added vanilla-extract recipe Add vanilla-extract recipe Nov 16, 2021
@beerose beerose merged commit 3479686 into canary Nov 16, 2021
@beerose beerose deleted the vanilla-extract branch November 16, 2021 13:29
@blitzjs-bot blitzjs-bot moved this from In Review to Done in Dashboard Nov 16, 2021
@dillondotzip dillondotzip changed the title Add vanilla-extract recipe [legacy-framework] Add vanilla-extract recipe Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants