Remove getLayout for reset-password.tsxs
#4017
Conversation
The other three auth templates have the `<Layout>` right in the component. This bringt the `reset-password` file(s) in line. It also gets rid of the empty wrapper-`<div>`.
🦋 Changeset detectedLatest commit: b5afe5f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey @tordans |
I don't think so. Those are my first commits to blitz so I never had a setup than worked. Did not look too much into and hoped the CI would show if there really is an error. This PR is just a cleanup to get the generated files in sync (this one is the only one using |
| "toolkit-app": patch | ||
| "toolkit-app-passport": patch |
There was a problem hiding this comment.
| "toolkit-app": patch | |
| "toolkit-app-passport": patch |
|
Hey sorry @tordans but it's better to use getLayout to prevent unmounting. It would be better to change the other uses of |
How this prevents unmounting? Could you provide more information please? I feel the docs are not enough to understand the problem. |
|
@vitaliemiron this explains it pretty well: https://adamwathan.me/2019/10/17/persistent-layout-patterns-in-nextjs/ |
|
closing in favor of #4146 |
What are the changes and their implications?
The other three auth templates have the
<Layout>right in the component. This brings thereset-passwordfile(s) in line. It also gets rid of the empty wrapper-<div>.Feature Checklist
I had trouble getting all tests running due to
ELIFECYCLEerrors. In case this is broken, feel free to just close the ticket.pnpm changesetin the root directory)Integration test added (see test docs if needed)Documentation added/updated (submit PR to blitzjs.com repomainbranch)