Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Extract out display package #589

Merged
merged 5 commits into from May 31, 2020

Conversation

ryardley
Copy link
Collaborator

@ryardley ryardley commented May 30, 2020

Closes: blitz-js/legacy-framework#913

What are the changes and their implications?

  • Extracted out display package
  • Remove server references from packages that don't use it

Checklist

  • Tests added for changes
  • User facing changes documented

Breaking change: no

Other information

@blitzjs-bot blitzjs-bot bot added this to In Progress in Dashboard May 30, 2020
@ryardley ryardley changed the title 588 extract out display package Extract out display package May 30, 2020
@ryardley ryardley marked this pull request as ready for review May 30, 2020 13:26
@blitzjs-bot blitzjs-bot bot moved this from In Progress to In Review in Dashboard May 30, 2020
flybayer
flybayer previously approved these changes May 30, 2020
merelinguist
merelinguist previously approved these changes May 30, 2020
@ryardley ryardley dismissed stale reviews from merelinguist and flybayer via a4654fb May 30, 2020 14:43
@ryardley
Copy link
Collaborator Author

ryardley commented May 31, 2020

@aem you ok we merge this?

@aem
Copy link
Collaborator

aem commented May 31, 2020

@ryardley yep! go for it

@ryardley ryardley merged commit c057bfd into canary May 31, 2020
Dashboard automation moved this from In Review to Done May 31, 2020
@ryardley ryardley deleted the 588-extract-out-display-package branch May 31, 2020 03:00
@dillondotzip dillondotzip changed the title Extract out display package [legacy-framework] Extract out display package Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Extract log out to it's own display package
4 participants