[legacy-framework] Add three lint rules to catch async/await promise bugs #662
Conversation
| @@ -64,7 +64,7 @@ transform.file = function transformFiles( | |||
| ) { | |||
| const mergedOpts = Object.assign({}, defaultStreamOptions, options) | |||
| return through(mergedOpts, async function (item: PipelineItem, _, next: StreamApi['next']) { | |||
| processInput({transformFn, next, self: this, filesOnly: true, item}) | |||
| await processInput({transformFn, next, self: this, filesOnly: true, item}) | |||
There was a problem hiding this comment.
@ryardley is it possible this will fix #632 ??
There was a problem hiding this comment.
Not sure. Streams are their own asynchronicity model and passing an async function as a transform doesn't have any effect on their behaviour as it is just a function that returns a promise chain instead of void. There is no try catch around the function passed to through so I don't see how this would change anything but maybe I could be wrong. Not sure if this means an error won't be swallowed or not. My favourite candidate for #632 is some kind of highwatermark issue but it is hard to investigate without reproducability. I am working on getting some kind of sensible debugging together to see if that can help.
There was a problem hiding this comment.
Doesn't seem to fix it in my codebase.
dillondotzip
changed the title
What are the changes and their implications?
This adds three new lint rules:
'@typescript-eslint/no-floating-promises': 'error''require-await': 'error''no-async-promise-executor': 'error'These will help prevent various types of async/await promise bugs.
In fact, I think this may help with blitz-js/legacy-framework#931 and maybe even fix it
Checklist