[legacy-framework] Fix blitz new dependency install issue (missing dependency in @blitzjs/generator)
#711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aem
approved these changes
Jun 22, 2020
flybayer
changed the title
blitz new dependency install issue (missing dependency in @blitzjs/generator)
dillondotzip
changed the title
blitz new dependency install issue (missing dependency in @blitzjs/generator)blitz new dependency install issue (missing dependency in @blitzjs/generator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: blitz-js/legacy-framework#918
What are the changes and their implications?
This adds the missing
gotdependency to the@blitzjs/generatorpackage.Checklist
Other
I think this was missed in #346 but I'm a little surprised we're just running into issues now. I was unable to reproduce blitz-js/legacy-framework#918 until I removed the global
blitzpackage and reinstalled it, so I guess it's possible people havegotcached in their globalnode_modulesor something, but... #346 was a long time ago. 馃し(Note:
yarn.lockchanges have nothing to do with this PR but... you know.)