[legacy-framework] Breaking: Upgrade React Query to v2 #720
+11
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flybayer
requested changes
Jun 30, 2020
There was a problem hiding this comment.
Awesome, thank you! Can you also open a PR to https://github.com/blitz-js/blitzjs.com to update the needed doc changes?
| @@ -22,7 +22,7 @@ const Products = () => { | |||
| ))} | |||
|
|
|||
| <div> | |||
| <button onClick={() => fetchMore()} disabled={!canFetchMore || isFetchingMore}> | |||
| <button onClick={() => fetchMore()} disabled={!canFetchMore || !!isFetchingMore}> | |||
There was a problem hiding this comment.
This is because the type of disabled is a boolean but the type of isFetchingMore has been changed from boolean to false | 'previous' | 'next'.
packages/core/package.json
Outdated
| @@ -43,7 +43,7 @@ | |||
| "@blitzjs/config": "0.15.3", | |||
| "@blitzjs/display": "0.15.3", | |||
| "pretty-ms": "6.0.1", | |||
| "react-query": "1.5.8", | |||
| "react-query": "^2.4.4", | |||
There was a problem hiding this comment.
This needs pinned to an exact version :)
Suggested change
| "react-query": "^2.4.4", | |
| "react-query": "2.4.4", |
|
By the way, always make sure your PRs have |
flybayer
changed the title
dillondotzip
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes the issue of Upgrade React Query to v2. blitz-js/legacy-framework#691
What are the changes and their implications?
Affected Change List
useQuery(ready && queryKey, queryFn)useQuery(queryKey, queryFn, { enabled: ready })useQuery(() => ['user', user.id], queryFn)useQuery(['user', user?.id], queryFn, { enabled: user?.id })refetchQuerieshas been renamed toinvalidateQueries. You will need make this rename change for your app to continue working propertly. The name change comes due to some differences in what the function does.queryKeyused inrefetchQueries(queryKey)and were also stale, would be refetched... even queries that were inactive and not rendered on the screen. This resulted in quite a few queries being refetched regardless of their immediate necessity.isFetchingMoreinInfiniteQueryResulthas been changed frombooleantofalse | 'previous' | 'next'.Checklist