Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Add user signup/login/logout to new app template #834

Merged
merged 5 commits into from Aug 4, 2020

Conversation

flybayer
Copy link
Member

@flybayer flybayer commented Aug 4, 2020

What are the changes and their implications?

This adds user signup/login/logout to new app template with react-final-form.

  • ⚠️ Does not add prompt for choice of form library. This will be done separately before the next latest release.
  • ⚠️ Does not automatically run DB migration during new app creation. This will be added separately.

Checklist

  • [ ] Tests added for changes
  • [ ] PR submitted to blitzjs.com for any user facing changes

@flybayer flybayer requested a review from aem as a code owner August 4, 2020 20:12
@blitzjs-bot blitzjs-bot bot added this to In Review in Dashboard Aug 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2020

Size Change: +91 B (0%)

Total Size: 172 kB

Filename Size Change
packages/generator/dist/templates/app/blitz.config.js 324 B +91 B (28%) 🚨
ℹ️ View Unchanged
Filename Size Change
packages/blitz/dist/cli.js 14.3 kB 0 B
packages/blitz/dist/index.js 245 B 0 B
packages/config/dist/config.cjs.development.js 1.35 kB 0 B
packages/config/dist/config.cjs.production.min.js 916 B 0 B
packages/config/dist/config.esm.js 1.28 kB 0 B
packages/config/dist/index.js 143 B 0 B
packages/core/dist/core.cjs.development.js 9.9 kB 0 B
packages/core/dist/core.cjs.production.min.js 5.77 kB 0 B
packages/core/dist/core.esm.js 9.54 kB 0 B
packages/core/dist/index.js 141 B 0 B
packages/display/dist/display.cjs.development.js 1.09 kB 0 B
packages/display/dist/display.cjs.production.min.js 587 B 0 B
packages/display/dist/display.esm.js 961 B 0 B
packages/display/dist/index.js 144 B 0 B
packages/file-pipeline/dist/file-pipeline.cjs.development.js 5.42 kB 0 B
packages/file-pipeline/dist/file-pipeline.cjs.production.min.js 2.69 kB 0 B
packages/file-pipeline/dist/file-pipeline.esm.js 5.27 kB 0 B
packages/file-pipeline/dist/index.js 147 B 0 B
packages/generator/dist/generator.cjs.development.js 14.5 kB 0 B
packages/generator/dist/generator.cjs.production.min.js 8.71 kB 0 B
packages/generator/dist/generator.esm.js 14.2 kB 0 B
packages/generator/dist/index.js 145 B 0 B
packages/installer/dist/index.js 145 B 0 B
packages/installer/dist/installer.cjs.development.js 7.72 kB 0 B
packages/installer/dist/installer.cjs.production.min.js 5.15 kB 0 B
packages/installer/dist/installer.esm.js 7.57 kB 0 B
packages/repl/dist/index.js 141 B 0 B
packages/repl/dist/repl.cjs.development.js 1.74 kB 0 B
packages/repl/dist/repl.cjs.production.min.js 1.01 kB 0 B
packages/repl/dist/repl.esm.js 1.62 kB 0 B
packages/server/dist/index.js 142 B 0 B
packages/server/dist/server.cjs.development.js 18.8 kB 0 B
packages/server/dist/server.cjs.production.min.js 10.8 kB 0 B
packages/server/dist/server.esm.js 18.8 kB 0 B

compressed-size-action

@flybayer flybayer merged commit 28e6a00 into canary Aug 4, 2020
Dashboard automation moved this from In Review to Done Aug 4, 2020
@flybayer flybayer deleted the auth-template branch August 4, 2020 20:55
@flybayer
Copy link
Member Author

flybayer commented Aug 4, 2020

P.S. You are still welcome to review this and comment even though I've merged. I've merge quickly so I can have it for my livestream with Kitze tomorrow :)

@dillondotzip dillondotzip changed the title Add user signup/login/logout to new app template [legacy-framework] Add user signup/login/logout to new app template Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant