Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Allow having pageName.test.tsx inside pages #850

Merged
merged 2 commits into from Aug 12, 2020

Conversation

flybayer
Copy link
Member

@flybayer flybayer commented Aug 8, 2020

What are the changes and their implications?

Because you often want test files to be co-located with the source file, this change allows you colocate page test files next to the page.

This change ensures page test files will not be added to the compiled pages folder.

Checklist

  • Tests added for changes
  • PR submitted to blitzjs.com for any user facing changes

@flybayer flybayer requested a review from ryardley as a code owner August 8, 2020 23:08
@blitzjs-bot blitzjs-bot bot added this to In Review in Dashboard Aug 8, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2020

Size Change: +23 B (0%)

Total Size: 174 kB

Filename Size Change
packages/server/dist/server.cjs.development.js 18.9 kB +8 B (0%)
packages/server/dist/server.cjs.production.min.js 10.8 kB +7 B (0%)
packages/server/dist/server.esm.js 18.9 kB +8 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/blitz/dist/cli.js 15.6 kB 0 B
packages/blitz/dist/index.js 245 B 0 B
packages/config/dist/config.cjs.development.js 1.35 kB 0 B
packages/config/dist/config.cjs.production.min.js 916 B 0 B
packages/config/dist/config.esm.js 1.28 kB 0 B
packages/config/dist/index.js 143 B 0 B
packages/core/dist/core.cjs.development.js 9.97 kB 0 B
packages/core/dist/core.cjs.production.min.js 5.79 kB 0 B
packages/core/dist/core.esm.js 9.61 kB 0 B
packages/core/dist/index.js 141 B 0 B
packages/display/dist/display.cjs.development.js 1.09 kB 0 B
packages/display/dist/display.cjs.production.min.js 587 B 0 B
packages/display/dist/display.esm.js 961 B 0 B
packages/display/dist/index.js 144 B 0 B
packages/file-pipeline/dist/file-pipeline.cjs.development.js 5.42 kB 0 B
packages/file-pipeline/dist/file-pipeline.cjs.production.min.js 2.69 kB 0 B
packages/file-pipeline/dist/file-pipeline.esm.js 5.27 kB 0 B
packages/file-pipeline/dist/index.js 147 B 0 B
packages/generator/dist/generator.cjs.development.js 14.5 kB 0 B
packages/generator/dist/generator.cjs.production.min.js 8.71 kB 0 B
packages/generator/dist/generator.esm.js 14.2 kB 0 B
packages/generator/dist/index.js 145 B 0 B
packages/generator/dist/templates/app/babel.config.js 77 B 0 B
packages/generator/dist/templates/app/blitz.config.js 324 B 0 B
packages/generator/dist/templates/app/jest.config.js 397 B 0 B
packages/generator/dist/templates/app/jest.setup.js 197 B 0 B
packages/installer/dist/index.js 145 B 0 B
packages/installer/dist/installer.cjs.development.js 7.72 kB 0 B
packages/installer/dist/installer.cjs.production.min.js 5.15 kB 0 B
packages/installer/dist/installer.esm.js 7.57 kB 0 B
packages/repl/dist/index.js 141 B 0 B
packages/repl/dist/repl.cjs.development.js 1.74 kB 0 B
packages/repl/dist/repl.cjs.production.min.js 1.01 kB 0 B
packages/repl/dist/repl.esm.js 1.62 kB 0 B
packages/server/dist/index.js 142 B 0 B

compressed-size-action

Copy link
Collaborator

@ryardley ryardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@peaonunes
Copy link
Collaborator

I did not consider they would be included in the production bundle. Sorry My fault!

@ryardley ryardley merged commit 90a7624 into canary Aug 12, 2020
Dashboard automation moved this from In Review to Done Aug 12, 2020
@ryardley ryardley deleted the test-pages branch August 12, 2020 01:54
@flybayer
Copy link
Member Author

@peaonunes no problem!

@dillondotzip dillondotzip changed the title Allow having pageName.test.tsx inside pages [legacy-framework] Allow having pageName.test.tsx inside pages Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants