Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Fix return types of useParam and useParams #902

Merged
merged 1 commit into from Aug 17, 2020

Conversation

flybayer
Copy link
Member

What are the changes and their implications?

The return type of useParam and useParams did not include <type> | undefined which is a bug. Because with Next.js pre-rendering, params can indeed be undefined, and so users must account for this.

Checklist

  • [ ] Tests added for changes
  • PR submitted to blitzjs.com for any user facing changes

@blitzjs-bot blitzjs-bot bot added this to In Review in Dashboard Aug 17, 2020
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 175 kB

ℹ️ View Unchanged
Filename Size Change
packages/blitz/dist/cli.js 15.6 kB 0 B
packages/blitz/dist/index.js 245 B 0 B
packages/config/dist/config.cjs.development.js 1.35 kB 0 B
packages/config/dist/config.cjs.production.min.js 916 B 0 B
packages/config/dist/config.esm.js 1.28 kB 0 B
packages/config/dist/index.js 143 B 0 B
packages/core/dist/core.cjs.development.js 10.2 kB 0 B
packages/core/dist/core.cjs.production.min.js 5.97 kB 0 B
packages/core/dist/core.esm.js 9.91 kB 0 B
packages/core/dist/index.js 141 B 0 B
packages/display/dist/display.cjs.development.js 1.09 kB 0 B
packages/display/dist/display.cjs.production.min.js 587 B 0 B
packages/display/dist/display.esm.js 961 B 0 B
packages/display/dist/index.js 144 B 0 B
packages/file-pipeline/dist/file-pipeline.cjs.development.js 5.42 kB 0 B
packages/file-pipeline/dist/file-pipeline.cjs.production.min.js 2.69 kB 0 B
packages/file-pipeline/dist/file-pipeline.esm.js 5.27 kB 0 B
packages/file-pipeline/dist/index.js 147 B 0 B
packages/generator/dist/generator.cjs.development.js 14.6 kB 0 B
packages/generator/dist/generator.cjs.production.min.js 8.74 kB 0 B
packages/generator/dist/generator.esm.js 14.3 kB 0 B
packages/generator/dist/index.js 145 B 0 B
packages/generator/dist/templates/app/babel.config.js 77 B 0 B
packages/generator/dist/templates/app/blitz.config.js 324 B 0 B
packages/generator/dist/templates/app/jest.config.js 654 B 0 B
packages/generator/dist/templates/app/test/__mocks__/fileMock.js 54 B 0 B
packages/installer/dist/index.js 145 B 0 B
packages/installer/dist/installer.cjs.development.js 7.72 kB 0 B
packages/installer/dist/installer.cjs.production.min.js 5.15 kB 0 B
packages/installer/dist/installer.esm.js 7.57 kB 0 B
packages/repl/dist/index.js 141 B 0 B
packages/repl/dist/repl.cjs.development.js 1.74 kB 0 B
packages/repl/dist/repl.cjs.production.min.js 1.01 kB 0 B
packages/repl/dist/repl.esm.js 1.62 kB 0 B
packages/server/dist/index.js 142 B 0 B
packages/server/dist/server.cjs.development.js 18.9 kB 0 B
packages/server/dist/server.cjs.production.min.js 10.9 kB 0 B
packages/server/dist/server.esm.js 18.9 kB 0 B

compressed-size-action

@flybayer flybayer merged commit 9441dfc into canary Aug 17, 2020
Dashboard automation moved this from In Review to Done Aug 17, 2020
@flybayer flybayer deleted the fix-useparam branch August 17, 2020 23:17
@dillondotzip dillondotzip changed the title Fix return types of useParam and useParams [legacy-framework] Fix return types of useParam and useParams Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant