Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 - Use Typescript #324

Open
4 tasks
abuuzayr opened this issue Jan 14, 2021 · 8 comments
Open
4 tasks

V2 - Use Typescript #324

abuuzayr opened this issue Jan 14, 2021 · 8 comments

Comments

@abuuzayr
Copy link
Collaborator

Since the initial setup of the V2 site was based on the tailwindcss.com repo, TS is not used. However, @cwray-tech did set it up when converting it to a Blitz repo.

In the spirit of keeping to Blitz.js's style, I think TS should be used.

  • Convert .js files to .ts
  • Convert .js files that require jsx tags to .tsx
  • Add type security
  • ...
@cwray-tech
Copy link
Collaborator

@abuuzayr sounds great to me!

@Mvrs
Copy link

Mvrs commented May 18, 2021

was wondering if you're converting the files to TypeScript how are you splitting what needs to be done first? @abuuzayr

@abuuzayr
Copy link
Collaborator Author

thanks @Mvrs would there be any issue if we started anywhere in particular? Sorry, I'm not a well-versed Typescript user..

Probably if there are common/shared types we will need to declare them somewhere first?

@Mvrs
Copy link

Mvrs commented May 18, 2021

@abuuzayr I think first making sure the config files down to the lint tools support ts, tsx file types. Looking at the files that share common types, hooks, and etc.

@abuuzayr
Copy link
Collaborator Author

ah, i get what you mean. when this issue was created, TS was set up but as of this commit 1f9d093 they were removed.

so yup you are right, we will have to set it all up again if we wish to use TS.

@Mvrs
Copy link

Mvrs commented May 18, 2021

Interesting... I wonder why the reason to move away from TypeScript before.

@flybayer
Copy link
Member

@JuanM04 why did you remove tsconfig awhile back?

@JuanM04
Copy link
Contributor

JuanM04 commented May 19, 2021

@flybayer because it wasn't being used. I changed it for a jsconfig knowing that we could recover it with Git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants