-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 - Use Typescript #324
Comments
@abuuzayr sounds great to me! |
was wondering if you're converting the files to TypeScript how are you splitting what needs to be done first? @abuuzayr |
thanks @Mvrs would there be any issue if we started anywhere in particular? Sorry, I'm not a well-versed Typescript user.. Probably if there are common/shared types we will need to declare them somewhere first? |
@abuuzayr I think first making sure the config files down to the lint tools support ts, tsx file types. Looking at the files that share common types, hooks, and etc. |
ah, i get what you mean. when this issue was created, TS was set up but as of this commit 1f9d093 they were removed. so yup you are right, we will have to set it all up again if we wish to use TS. |
Interesting... I wonder why the reason to move away from TypeScript before. |
@JuanM04 why did you remove tsconfig awhile back? |
@flybayer because it wasn't being used. I changed it for a jsconfig knowing that we could recover it with Git |
Since the initial setup of the V2 site was based on the tailwindcss.com repo, TS is not used. However, @cwray-tech did set it up when converting it to a Blitz repo.
In the spirit of keeping to Blitz.js's style, I think TS should be used.
.js
files to.ts
.js
files that requirejsx
tags to.tsx
The text was updated successfully, but these errors were encountered: