Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a proto equivalent to sc2_typeenums.h #16

Open
Databean opened this issue Aug 11, 2017 · 2 comments
Open

Add a proto equivalent to sc2_typeenums.h #16

Databean opened this issue Aug 11, 2017 · 2 comments

Comments

@Databean
Copy link

https://github.com/Blizzard/s2client-api/blob/master/include/sc2api/sc2_typeenums.h

As sc2_typeeenums.h says, "All units and abilities are represented as unsigned numbers in the StarCraft II engine. This can make issue abilities unnecessarily hard."

This fact is also true with the proto API. As it is, any equivalent implementation of the sc2api client in another language will have to define its own equivalent of these enums, or force its users to figure out the unit indexes themselves.

Is it possible to define this as a protobuf enum as part of the protocol sent by the game?

@AnthonyBrunasso
Copy link
Contributor

We definitely agree with you and have added this as something we will implement. We're not sure what the timeline will be on it though.

Thanks for bringing this up.

@carlos-sarmiento
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants