Add extra delete and some comments, also fetch better the last blolck… #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… query from memory not disk
| var utxos = new List<UnspentOutputTable>(storageBatch.OutputTable.Values.Count); | ||
|
|
||
| foreach (OutputTable outputTable in storageBatch.OutputTable.Values) | ||
| { | ||
| if (outputTable.Address.Equals(OpReturnAddress)) | ||
| continue; | ||
|
|
||
| // TODO: filter out outputs that are already spent in the storageBatch.InputTable table |
There was a problem hiding this comment.
This will impact blocks where both the output and input are created
| // this is an edge case, we delete from the utxo table in case a bath push failed half way and left | ||
| // item in the utxo table that where suppose to get deleted, to avoid duplicates in recovery processes | ||
| // we delete just in case (the utxo table has a unique key on outputs), there is no harm in deleting twice. | ||
| FilterDefinition<UnspentOutputTable> unspentOutputFilter1 = |
There was a problem hiding this comment.
We can use the same filter on both delete operations
DavidGershony
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… query from memory not disk