Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIKit doesn't render spinners in React #44

Closed
ghost opened this issue Mar 21, 2018 · 1 comment
Closed

UIKit doesn't render spinners in React #44

ghost opened this issue Mar 21, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented Mar 21, 2018

Expected behavior (user story)

I want to use uk-spinner inside JSX so that it renders properly.

Actual behavior

uk-spinner is placed inside DOM with decorated element (i.e. span or div) but remains invisible (has 0px width).

Steps to reproduce

Reproduced using either uikit@3.0.0-beta.40 or uikit@3.0.0-beta.22
In JSX template, placing:
<div className="uk-spinner"></div>,
<div data-uk-spinner></div>, or
<span data-uk-spinner={''} />
will not result in proper rendering.

This issue mimics:
uikit/uikit#2663

Is falling back to UIKit@2.x.x an option?

@michalmikolajczyk
Copy link
Member

nope, we should go with the new UIKit. spinners are not the most important, we can use different spinners. Like this stuff: http://www.davidhu.io/react-spinners/

Please create a new task if you want to add a spinner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant