Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StorageHandledByDB should return the right chainId #123

Closed
pikonha opened this issue Jun 20, 2024 · 0 comments
Closed

StorageHandledByDB should return the right chainId #123

pikonha opened this issue Jun 20, 2024 · 0 comments
Assignees
@pikonha
Labels
bug Something isn't working

Comments

@pikonha
Copy link
Contributor

pikonha commented Jun 20, 2024 •
edited
Loading

The current Database Resolver implementation only exposes the chain id as being mainnet, which causes the integration with Metamask to fail on the front end.

It should have the right chain id based on the networked it has been deployed to.

    uint64 private constant _CHAIN_ID = 1;

The possible solution is to set the chain ID during the deployment and make it immutable.
@pikonha pikonha self-assigned this Jun 20, 2024
@pikonha pikonha added the bug Something isn't working label Jun 20, 2024
@pikonha pikonha mentioned this issue Jun 20, 2024
Merged
10 tasks
@pikonha pikonha closed this as completed by moving to ✅ Done in ENS Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pikonha pikonha

Labels
bug Something isn't working
Projects
ENS
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pikonha