Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/f leave bug #52

Closed
iZeaoGamer opened this issue Aug 30, 2018 · 7 comments
Closed

/f leave bug #52

iZeaoGamer opened this issue Aug 30, 2018 · 7 comments

Comments

@iZeaoGamer
Copy link
Contributor

The bug's still there, where if you're the leader of your faction, you can use /f leave, and then, you can use /f disband, which crashes the server. Maybe make it so only faction members can use /f leave, and not the leaders.

@Kris-Driv
Copy link
Contributor

That's not a solution. Logic behind is that when leader leaves the faction, leadership will be given to next faction member. Higher roles have higher priority to become leader. I'll take a look at this. But did I fix /f perm list ?

@iZeaoGamer
Copy link
Contributor Author

Yes.

@iZeaoGamer
Copy link
Contributor Author

Okay, I've found the confirmed exploit for /f disband. It's simple - You basically make sure you're not in a faction, and if you do /f disband when not in a faction, it crashes the server. Maybe add like "You're not a leader of this faction" or some message to prevent this happening. Or maybe somehow fix this issue your way. Thanks.

@Kris-Driv
Copy link
Contributor

Pull latest commit. I wasn't able to replicate this.

@iZeaoGamer
Copy link
Contributor Author

What?

@Kris-Driv
Copy link
Contributor

This commit 195d7b4 fixed this issue and any other issues regarding PocketMine exiting without any signs. Thanks for reporting 😄

@iZeaoGamer
Copy link
Contributor Author

Okay, thanks for fixing this bug! You guys are truely amazing! Keep up the great work! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants