-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: "I don't have a wallet" flow + Progress-bar fixup #1535
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Adamj1232 When I test in the demo- the three dots below the "I don't have a wallet" link are not spacing as nicely as you in your demo pics: |
@katspaugh thanks for catching that! Needed to push the commit removing a sneaky single quote breaking everything! Should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good- was able to test locally and add a custom link and test the default
* update root path (#1543) * Add XDEFI module and injected to docs site (#1544) * Add xdefi to docs * Add xdefi module to docs * Add xdefi package to docs onboard * Add to injected wallets list * Feature: "I don't have a wallet" flow + Progress-bar fixup (#1535) * Link working and styled * Progress bar work * Cleanup progressbar code * Remove single quote breaking view * Revert TP testing code * add transaction preview graphic * add transaction preview install code snippet * move md code snippets - update imports * add transaction preview section to landing page * update theming code snippet * update hero section install code * update account center graphic * update hero w3o graphic * update account center svg * Update README.md (#1547) Yeah maybe this needs more thorough changes throughout the docs but I was caught up on this for a minute, and this will help * move transaction preview section to top * update link url * Added XDEFI to readme * Add theming docs, refine core init options, api actions and code chunks (#1548) * Add theming docs, still needs refinement * More docs * Add theming video * More docs * Update layout and add copy to some code chunks * Add dividers for better visibility between options and copy to code blocks where useful * Reorder Theming docs layout * Add note about ethers v6 usage * edit theming page - add css variables table - edit theme descriptions - re-org existing content * Update docs/src/lib/components/examples/connect-wallet/ReactConnectWallet.md * Update theming tool to default to custom --------- Co-authored-by: Gustavo Esquinca <g.esq.ca@gmail.com> * Update docs/src/lib/components/code-snippet/theming-code.md Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Bump versions for release * Add Infinity Wallet Connector (#1540) * Add Infinity Wallet Connector * Update packages/infinity-wallet/package.json * Update packages/infinity-wallet/src/index.ts * Remove yarn lock from infin package * Update packages/demo/package.json * Add inifinity to docs * Reorder wallets * Update docs title * Bump innjected package version --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * [walletconnect-2.3.0-alpha.3] - Feat: Walletconnect URI handler + bump wc package version (#1552) * accept handleUri prop * Update docs * Rename wc prop to handleUri * Bump wc pakcage version for walletconnect/ethereum-provider * merge in dev * Revert unintended change * Update prop in docs * Cleanup semicolon * Yarn it! * Bump undici from 5.10.0 to 5.19.1 in /examples/with-sveltekit (#1532) Bumps [undici](https://github.com/nodejs/undici) from 5.10.0 to 5.19.1. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.10.0...v5.19.1) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Update fortmatic docs --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com> Co-authored-by: Gustavo Esquinca <g.esq.ca@gmail.com> Co-authored-by: Brent <46073594+Brentably@users.noreply.github.com> Co-authored-by: mhchaudhry3 <mobeen@blocknative.com> Co-authored-by: mhchaudhry3 <102989386+mhchaudhry3@users.noreply.github.com> Co-authored-by: Aaron <53439560+arons1@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description
This PR adds the configurable "I don't have a wallet" link to the sidebar of the connect modal along with fixing the progress bar to match the designs (specifically for desktop as mobile matched already)
The "I don't have a wallet" link is configurable within the
connect
object inside the onboard configChecklist
package.json
of the package you have made changes in is incremented following semantic versioning and using alpha release taggingyarn file-check
,yarn type-check
&yarn build
to confirm there are not any associated errors