Add Infinity Wallet Connector #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@arons1 thanks for the PR! We will take a look at this in the next couple days |
Adamj1232
reviewed
Feb 22, 2023
Adamj1232
reviewed
Feb 22, 2023
Adamj1232
reviewed
Feb 22, 2023
Adamj1232
reviewed
Feb 22, 2023
| checkProviderIdentity: ({ provider }) => | ||
| !!provider && !!provider[ProviderIdentityFlag.InfinityWallet], | ||
| getIcon: async () => (await import('./icons/infinitywallet.js')).default, | ||
| getInterface: getInjectedInterface(ProviderIdentityFlag.InfinityWallet), |
There was a problem hiding this comment.
Has this been tested through the injected package without the sdk added within the local demo project?
I saw it was removed from the PR checklist.
Sometimes getInjectedInterface is not the correct method and createEIP1193Provider is better suited depending on the wallet
Adamj1232
requested changes
Feb 22, 2023
There was a problem hiding this comment.
Looking good! Thank you again for the PR!
A few changes requested noted in the comments.
You will also want to add Infinity to the docs site that is part of this repo.
Checkout this PR for an example of adding to the docs site.
You will need to use yarn link to ensure the module works within the docs site.
Adamj1232
reviewed
Feb 24, 2023
This was referenced Feb 27, 2023
Merged
Merged
Adamj1232
added a commit
that referenced
this pull request
Feb 28, 2023
* update root path (#1543) * Add XDEFI module and injected to docs site (#1544) * Add xdefi to docs * Add xdefi module to docs * Add xdefi package to docs onboard * Add to injected wallets list * Feature: "I don't have a wallet" flow + Progress-bar fixup (#1535) * Link working and styled * Progress bar work * Cleanup progressbar code * Remove single quote breaking view * Revert TP testing code * add transaction preview graphic * add transaction preview install code snippet * move md code snippets - update imports * add transaction preview section to landing page * update theming code snippet * update hero section install code * update account center graphic * update hero w3o graphic * update account center svg * Update README.md (#1547) Yeah maybe this needs more thorough changes throughout the docs but I was caught up on this for a minute, and this will help * move transaction preview section to top * update link url * Added XDEFI to readme * Add theming docs, refine core init options, api actions and code chunks (#1548) * Add theming docs, still needs refinement * More docs * Add theming video * More docs * Update layout and add copy to some code chunks * Add dividers for better visibility between options and copy to code blocks where useful * Reorder Theming docs layout * Add note about ethers v6 usage * edit theming page - add css variables table - edit theme descriptions - re-org existing content * Update docs/src/lib/components/examples/connect-wallet/ReactConnectWallet.md * Update theming tool to default to custom --------- Co-authored-by: Gustavo Esquinca <g.esq.ca@gmail.com> * Update docs/src/lib/components/code-snippet/theming-code.md Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Bump versions for release * Add Infinity Wallet Connector (#1540) * Add Infinity Wallet Connector * Update packages/infinity-wallet/package.json * Update packages/infinity-wallet/src/index.ts * Remove yarn lock from infin package * Update packages/demo/package.json * Add inifinity to docs * Reorder wallets * Update docs title * Bump innjected package version --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * [walletconnect-2.3.0-alpha.3] - Feat: Walletconnect URI handler + bump wc package version (#1552) * accept handleUri prop * Update docs * Rename wc prop to handleUri * Bump wc pakcage version for walletconnect/ethereum-provider * merge in dev * Revert unintended change * Update prop in docs * Cleanup semicolon * Yarn it! * Bump undici from 5.10.0 to 5.19.1 in /examples/with-sveltekit (#1532) Bumps [undici](https://github.com/nodejs/undici) from 5.10.0 to 5.19.1. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.10.0...v5.19.1) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Update fortmatic docs --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com> Co-authored-by: Gustavo Esquinca <g.esq.ca@gmail.com> Co-authored-by: Brent <46073594+Brentably@users.noreply.github.com> Co-authored-by: mhchaudhry3 <mobeen@blocknative.com> Co-authored-by: mhchaudhry3 <102989386+mhchaudhry3@users.noreply.github.com> Co-authored-by: Aaron <53439560+arons1@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Infinity Web3 Browser connector and added as an option in the web3 onboard modal.
Checklist
package.jsonof the package you have made changes in is incremented following semantic versioning and using alpha release taggingyarn file-check,yarn type-check&yarn buildto confirm there are not any associated errorsIf this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/Tests with demo app (SDK)