-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return old style menu #2797
Return old style menu #2797
Conversation
Pull Request Test Coverage Report for Build fa22b8e9-8786-4031-be9a-7d4034ec033e
💛 - Coveralls |
212e4bc
to
4505c2d
Compare
4505c2d
to
2bb69f7
Compare
what's wrong with the current menu? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vbaranov gettext
is failing
fixed
Nothing wrong from my perspective. The main reason to return to the previous one is currently a reduced number of chains in the menu. No need to overlap the full screen in mobile view or search capability having only 7 chains there. Maybe @igorbarinov can share more context of that change. Anyways, the new menu can be returned if needed in the future. |
Motivation
The new menu did not take root
Before:
![Screenshot 2019-10-22 at 19 02 22](https://user-images.githubusercontent.com/4341812/67305754-8747a200-f4fe-11e9-9b40-cbad9ef3a778.png)
![Screenshot 2019-10-22 at 19 02 36](https://user-images.githubusercontent.com/4341812/67305761-89a9fc00-f4fe-11e9-942b-28c6ea2158f4.png)
After:
![Screenshot 2019-10-22 at 17 58 54](https://user-images.githubusercontent.com/4341812/67305688-6b440080-f4fe-11e9-80d0-78177433ab30.png)
![Screenshot 2019-10-22 at 18 22 51](https://user-images.githubusercontent.com/4341812/67305692-6da65a80-f4fe-11e9-9f11-9b7732e05984.png)
Changelog
Enhancements
Things you added that don't break anything. Regression tests for Bug Fixes count as Enhancements.
Bug Fixes
Things you changed that fix bugs. If a fixes a bug, but in so doing adds a new requirement, removes code, or requires a database reset and reindex, the breaking part of the change should be added to Incompatible Changes below also.
Incompatible Changes
Things you broke while doing Enhancements and Bug Fixes. Breaking changes include (1) adding new requirements and (2) removing code. Renaming counts as (2) because a rename is a removal followed by an add.
Upgrading
If you have any Incompatible Changes in the above Changelog, outline how users of prior versions can upgrade once this PR lands or when reviewers are testing locally. A common upgrading step is "Database reset and re-index required".
Checklist for your Pull Request (PR)
CHANGELOG.md
with this PRmaster
in the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.