Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return old style menu #2797

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Return old style menu #2797

merged 2 commits into from
Oct 29, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Oct 22, 2019

Motivation

The new menu did not take root

Before:
Screenshot 2019-10-22 at 19 02 22
Screenshot 2019-10-22 at 19 02 36

After:
Screenshot 2019-10-22 at 17 58 54
Screenshot 2019-10-22 at 18 22 51

Changelog

Enhancements

Things you added that don't break anything. Regression tests for Bug Fixes count as Enhancements.

Bug Fixes

Things you changed that fix bugs. If a fixes a bug, but in so doing adds a new requirement, removes code, or requires a database reset and reindex, the breaking part of the change should be added to Incompatible Changes below also.

Incompatible Changes

Things you broke while doing Enhancements and Bug Fixes. Breaking changes include (1) adding new requirements and (2) removing code. Renaming counts as (2) because a rename is a removal followed by an add.

Upgrading

If you have any Incompatible Changes in the above Changelog, outline how users of prior versions can upgrade once this PR lands or when reviewers are testing locally. A common upgrading step is "Database reset and re-index required".

Checklist for your Pull Request (PR)

@vbaranov vbaranov added the wip label Oct 22, 2019
@coveralls
Copy link

coveralls commented Oct 22, 2019

Pull Request Test Coverage Report for Build fa22b8e9-8786-4031-be9a-7d4034ec033e

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 76.589%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/catchup/bound_interval_supervisor.ex 3 85.19%
Totals Coverage Status
Change from base Build 7eac4942-59b6-478f-ba79-37b9eb8c6f07: -0.01%
Covered Lines: 5303
Relevant Lines: 6924

💛 - Coveralls

@vbaranov vbaranov added ready for review This PR is ready for reviews. and removed wip labels Oct 23, 2019
@vbaranov vbaranov marked this pull request as ready for review October 23, 2019 13:21
@ayrat555
Copy link
Contributor

what's wrong with the current menu?

@vbaranov vbaranov self-assigned this Oct 25, 2019
Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbaranov gettext is failing

@vbaranov
Copy link
Member Author

@ayrat555 @pasqu4le

gettext is failing

fixed

what's wrong with the current menu?

Nothing wrong from my perspective. The main reason to return to the previous one is currently a reduced number of chains in the menu. No need to overlap the full screen in mobile view or search capability having only 7 chains there. Maybe @igorbarinov can share more context of that change. Anyways, the new menu can be returned if needed in the future.

@vbaranov vbaranov merged commit 117e142 into master Oct 29, 2019
@vbaranov vbaranov deleted the vb-revert-old-school-menu branch October 29, 2019 12:45
@vbaranov vbaranov mentioned this pull request Nov 7, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants