Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove networks images preload #2846

Merged
merged 2 commits into from
Nov 12, 2019
Merged

Remove networks images preload #2846

merged 2 commits into from
Nov 12, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Nov 7, 2019

Motivation

After returning of old networks menu #2797, networks images preload wasn't removed #2570

Changelog

Remove preload of network images for enhanced networks menu since that menu was disabled for a while and networks menu styles itself

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-remove-images-preload branch 2 times, most recently from 8903019 to 58a615b Compare November 7, 2019 14:52
@vbaranov vbaranov self-assigned this Nov 7, 2019
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Nov 7, 2019
@vbaranov vbaranov marked this pull request as ready for review November 7, 2019 14:53
@coveralls
Copy link

coveralls commented Nov 7, 2019

Pull Request Test Coverage Report for Build eb194103-058e-4689-a97f-6e84f6686571

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 60 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.8%) to 75.641%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/transform/addresses.ex 1 75.0%
apps/block_scout_web/lib/block_scout_web/views/layout_view.ex 2 86.36%
apps/indexer/lib/indexer/block/fetcher.ex 3 83.13%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/http.ex 7 64.0%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/web_socket/web_socket_client.ex 47 18.75%
Totals Coverage Status
Change from base Build edb464cc-8f27-47bb-976a-e7c21c530861: -0.8%
Covered Lines: 5248
Relevant Lines: 6938

💛 - Coveralls

@vbaranov vbaranov merged commit 7286cbf into master Nov 12, 2019
@vbaranov vbaranov deleted the vb-remove-images-preload branch November 12, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants