Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Create faucet page #1047

Closed
markmhendrickson opened this issue Apr 6, 2020 · 22 comments
Closed

Create faucet page #1047

markmhendrickson opened this issue Apr 6, 2020 · 22 comments
Assignees

Comments

@markmhendrickson
Copy link

markmhendrickson commented Apr 6, 2020

STX

Webflow page

@markmhendrickson markmhendrickson changed the title Create STX faucet page Create BTC faucet page Apr 6, 2020
@markmhendrickson markmhendrickson changed the title Create BTC faucet page Create faucet page Apr 6, 2020
@markmhendrickson
Copy link
Author

@jasperjansz will add both BTC and STX forms in Figma, integrate into Webflow, then assign @hstove for end-to-end integration there.

@markmhendrickson
Copy link
Author

Need to release just STX faucet for Neon

@markmhendrickson
Copy link
Author

@hstove Let's be sure to add basic input pattern validation here when you wire it up (eg minimum address length)

@markmhendrickson
Copy link
Author

I'll wire up the success and error states now that Hank has the API set up

@markmhendrickson
Copy link
Author

The states are wired up, but @hstove needs to confirm now that the API always returns proper HTTP codes for success and errors. Once that's confirmed, we can move to QA.

@markmhendrickson
Copy link
Author

@hstove I'm still seeing the API return success for incorrect address inputs – is that expected?

@markmhendrickson
Copy link
Author

Screen Shot 2020-04-22 at 09.35.35.png

@timstackblock
Copy link

CORS error on the faucet

Screen Shot 2020-04-22 at 8.38.35 AM.png

@markmhendrickson
Copy link
Author

Weird – the API must be actively evolving today 🐛

@timstackblock
Copy link

timstackblock commented Apr 22, 2020

Yea things are still changing it may be to early to test, the form specifies the field name as STX-Address but the api endpoint expects address.

@zone117x
Copy link

zone117x commented Apr 22, 2020

Faucet endpoint was previously just stubbed out. It is actually implemented now -- but the request page form needs modified a bit to work.

@markmhendrickson
Copy link
Author

@jasperjansz has made the field change. @timstackblock can you test again?

@timstackblock
Copy link

timstackblock commented Apr 22, 2020

Getting a 500 error now.

Screen Shot 2020-04-22 at 10 55 54 AM

@markmhendrickson
Copy link
Author

@zone117x is this something you can fix on the API side?

@zone117x
Copy link

Technically yes, but the API should not be using an adhoc label for the address field

@markmhendrickson
Copy link
Author

Adhoc label? Not sure I follow 🦋 :thinking_face: 🥚

@markmhendrickson
Copy link
Author

Getting a 500 error from the API when entering a valid STX address that we need to change ASAP for launch. @zone117x @hstove ?

Screen Shot 2020-04-23 at 09.49.33.png

@timstackblock
Copy link

Screen Shot 2020-04-24 at 8.19.13 AM.png

@timstackblock
Copy link

timstackblock commented Apr 24, 2020

The errors above are resolved, we still need to make sure that addresses created from the CLI wallet can receive tokens, is this currently possible with the testnet? @hstove @yknl doesnt seem to be working right now.

@markmhendrickson
Copy link
Author

@hstove @yknl can one of you confirm whether addresses from the CLI wallet should work with this faucet?

@yknl
Copy link
Collaborator

yknl commented Apr 27, 2020

Yes any valid address generated for the correct network will work for receiving tokens. In this case the CLI just needs to be querying the right core node API to retrieve the balance. That's currently working using the steps on the Testnet CLI docs.

@timstackblock
Copy link

Ok I will test this when the CLI changes are complete thank @yknl

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants