Skip to content
This repository has been archived by the owner on Apr 15, 2021. It is now read-only.

fix: serialize uint strings with literal u prefix #98

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

reedrosenbluth
Copy link
Contributor

@reedrosenbluth reedrosenbluth commented Jul 2, 2020

Description

This PR introduces a slight change to the cvToString() function. Uints are now serialized like "u10" instead of like "10".

Issue: https://github.com/blockstack/stacks-blockchain/issues/1699

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Does this introduce a breaking change?

No

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • Tag 1 of @yknl, @zone117x, @reedrosenbluth for review

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files          28       28           
  Lines        1802     1802           
  Branches      367      367           
=======================================
  Hits         1514     1514           
  Misses        286      286           
  Partials        2        2           
Impacted Files Coverage Δ
src/clarity/clarityValue.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc0ad72...11c555a. Read the comment docs.

Copy link
Collaborator

@yknl yknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reedrosenbluth reedrosenbluth merged commit ad37843 into master Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants