-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
combinePubKeys should not allow for n_pubkeys==1 #89
Comments
why wouldn't it? n_pubkeys = 1 is well defined and has an obvious sensible behaviour. If the interface forces more than one then a caller needs to handle an additional corner case that would otherwise just work. |
Hm. You can also combine the same pubkey n times with itself. I don't have a use case for this either but it's not broken or wrong in any sense, so I tend not to put restrictions here. But you're right, it's somehow confusing. I'm indifferent. |
Ok, if the current behavior is to be kept, it would be nice to document it. How about a footnote in |
I'd rather not complicate the exposition for the sake of this usecase. The current text makes sense for n=1 (aside from being ungrammatical) and it never occurred to me that n=1 might not work. Though perhaps I am just too close to this. |
I don't understand what's the issue here. Does the function not do exactly what you'd expect with 1 input? Look at Python's |
There is this line in combine_pubkeys:
ARG_CHECK(n_pubkeys > 0);
Given that it doesn't make sense for n_pubkeys to be 1, I was wondering if this check should be changed to be "> 1"?
The text was updated successfully, but these errors were encountered: