followSymlinks option #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blond
force-pushed
the
issue-123
branch
3 times, most recently
from
1471486
to
2812e44
Compare
vitkarpov
reviewed
Jan 11, 2018
|
|
||
| copySymlink(file.path, dest, { fs }) | ||
| .then(() => callback()) | ||
| .catch(callback); |
There was a problem hiding this comment.
Why not () => callback() as a line above?
There was a problem hiding this comment.
because .catch(err => callback(err))
mrmlnc
approved these changes
Jan 11, 2018
lib/fs/copy-symlink.js
Outdated
| const nativeFs = require('fs'); | ||
| const path = require('path'); | ||
|
|
||
| const promisify = require('es6-promisify'); |
There was a problem hiding this comment.
Why not pify? The pify has optimizations for v8 like native promisify from util – https://github.com/sindresorhus/pify/blob/master/optimization-test.js.
lib/fs/copy-symlink.js
Outdated
| const destDir = path.dirname(destPath); | ||
|
|
||
| const fs = opts.fs || nativeFs; | ||
| const readlink = promisify(fs.readlink); |
There was a problem hiding this comment.
May be we can move it to top of this module? Now the promisify function will be called for each call of fs/copy-symlink. This is less than ms but it's free ms.
| * @abstract | ||
| */ | ||
| // eslint-disable-next-line class-methods-use-this | ||
| addSymbolicLink(file, callback) { // eslint-disable-line no-unused-vars |
added 6 commits
January 11, 2018 15:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followSymlinks: follow symlinked files and directories. If symlink is broken, tartifacts falls with error.