Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

872/allow for unit sets to have multiple ami charts #1678

Merged
merged 6 commits into from
Aug 20, 2021
Merged

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Aug 17, 2021

Pull Request Template

Issue

Addresses #872

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Allows for sets of units to have multiple AMI charts, and in doing so updates the HMI chart visually to display ranges of maximum income values if there are multiple AMI charts in use. Also fixes some existing sorting bugs, fixes the BMR chart seed which I discovered wasn't working, and adds two new seeds to test this behavior that will render each flavor of the HMI table with multiple AMI charts. Screenshots of them both below. I essentially re-wrote the function and added a few comments to try to make it more readable but I don't know that I succeeded there 😨

Screen Shot 2021-08-16 at 7 08 17 PM
Screen Shot 2021-08-16 at 6 30 42 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Check out the new seeds, and the existing seeds against the tables on dev to ensure they didn't break.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes

@emilyjablonski emilyjablonski added the wip This PR is not ready for review, do not review it's a “Work In Progress” label Aug 17, 2021
@netlify
Copy link

netlify bot commented Aug 17, 2021

❌ Deploy Preview for dev-bloom failed.

🔨 Explore the source changes: 988dc87

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/611fbf5bc008920007ac3747

@netlify
Copy link

netlify bot commented Aug 17, 2021

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: 988dc87

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/611fbf5ba1c7170008628640

😎 Browse the preview: https://deploy-preview-1678--dev-partners-bloom.netlify.app

@netlify
Copy link

netlify bot commented Aug 17, 2021

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 988dc87

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/611fbf5bcc6d0c000813f57c

😎 Browse the preview: https://deploy-preview-1678--dev-storybook-bloom.netlify.app

@@ -1,18 +1,47 @@
import { ListingDefaultSeed } from "./listing-default-seed"
import { getDefaultUnits } from "./shared"
import { getDefaultUnits, getDefaultProperty, getDefaultAmiChart } from "./shared"
Copy link
Collaborator Author

@emilyjablonski emilyjablonski Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seed listing just wasn't working anymore and we must have missed it - so now I'm actually adding the appropriate units so we get the BMR chart. This was indirectly related to the PR but I needed to test with this data

@@ -32,85 +34,131 @@ const minMaxCurrency = (baseValue: MinMaxCurrency, newValue: number): MinMaxCurr
}
}

const bmrHeaders = ["Studio", "1 BR", "2 BR", "3 BR", "4 BR"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is alllll sorts of borked, I don't have a great suggestion besides checking out the new fxn on its own, I changed a lot 😭

@emilyjablonski emilyjablonski marked this pull request as ready for review August 17, 2021 01:16
@emilyjablonski emilyjablonski added ready for review and removed wip This PR is not ready for review, do not review it's a “Work In Progress” labels Aug 17, 2021
@emilyjablonski
Copy link
Collaborator Author

I'll make another issue but I also realized in the process of doing this that a few things in this table aren't translated (existing issue)

Copy link
Collaborator

@seanmalbert seanmalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilyjablonski , I'm impressed that you were able to get this refactor turned around so quickly, that hmiData method is not easy to follow, at least for me. There are a couple of places that I noticed where I think we can make some improvement. Please see my comments. The main one is having to do with how we're handling and referencing the ami charts. Please let me know if you have any questions.

backend/core/src/shared/units-transformations.ts Outdated Show resolved Hide resolved
Comment on lines +58 to +66
const uniquePercentageChartSet: ChartAndPercentage[] = [
...new Set(
units
.map((unit) => {
return { percentage: parseInt(unit.amiPercentage, 10), chart: unit.amiChart }
})
.map((item) => JSON.stringify(item))
),
].map((uniqueSetString) => JSON.parse(uniqueSetString))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be more efficient to only reference the amiChart id here and not the full chart. If I'm reading this hmiData function correctly, the only place we need to know the actual chart item data is in findAmiValueInChart, so if you updated that function to take the chart id, and used that to get the chart data, I think some of this could be simplified. This does mean that ami charts would need to be fetched separately, but that could and probably should be cached, since I doubt they change very frequently. While this probably doesn't really help speed up processing time, it should reduce the amount of memory used, especially when you take into account that we could take this approach with ami charts everywhere and only ever request the chart id along with listing units.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me and I can see the memory gains, but currently I don't think we have access to the amiChart id here without other backend changes. The Unit entity only has the amiChart as AmiChart. So I think we need the other PR's changes to move forward with that improvement.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fine, since that PR does fetch the ami charts, we can swap that out there.

@slowbot
Copy link
Collaborator

slowbot commented Aug 18, 2021

@emilyjablonski We still need to add per year and per month where appropriate on the table values and wrap content of the cell to multiple lines if needed

image
image

@emilyjablonski
Copy link
Collaborator Author

emilyjablonski commented Aug 18, 2021

@slowbot The content wraps where needed already so we should be good to go there, and it will be a little challenging to add the per month and per year since we're just passing translation keys and not pre-translated text and we don't have a way to do that yet for ranges. I would love to do that in a separate PR if that's okay since this one is blocking? (#1691)

@slowbot
Copy link
Collaborator

slowbot commented Aug 18, 2021

@emilyjablonski Separate PR is fine with me

Copy link
Collaborator

@seanmalbert seanmalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilyjablonski ,
Looks good, just one request before you merge to swap a map and filter placement. See comment in code.

// All unique AMI percentages across all units
const allPercentages: number[] = [
...new Set(
units.map((unit) => parseInt(unit.amiPercentage, 10)).filter((item) => item != null)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilyjablonski , this looks good, can you just switch the order of the filter and map.

Comment on lines +58 to +66
const uniquePercentageChartSet: ChartAndPercentage[] = [
...new Set(
units
.map((unit) => {
return { percentage: parseInt(unit.amiPercentage, 10), chart: unit.amiChart }
})
.map((item) => JSON.stringify(item))
),
].map((uniqueSetString) => JSON.parse(uniqueSetString))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fine, since that PR does fetch the ami charts, we can swap that out there.

@emilyjablonski emilyjablonski merged commit ed17d89 into dev Aug 20, 2021
@emilyjablonski emilyjablonski deleted the 872/ami-take2 branch August 20, 2021 15:07
seanmalbert added a commit that referenced this pull request Aug 20, 2021
* 1545/lat-long draggable map (#1577)

* 1616/user roles (#1673) from 1628

* User roles for partners

* generate migration

* update client

* update seeds and policy

* migrate partners from leasing agent table

* change enum name

* Remove anonymous role

* Update authz.service.ts

* fix application view

* update changelog

* fix backend tests

* add test

* fix ui tests

Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>

* Fix code style issues with Prettier

* 1587/Updates Listing Columns and Perms so Leasing Agents can Edit (#1627)

* updates for cache revalidation on the frontend

* fixes listing bug issue

* Updates partner listings columns

* updates policy and user perms

* skips tests until #1616 is implemented

* updates to work with new user roles

* remove origin from listing service list args

* test update

* Fix code style issues with Prettier

* Split Listing form up into two main tabs (#1644)

* Add tabs to the listing form

* Fix button positions and ensure tabs always render

* Add #1644 to Changelog

* fixes warning for ArrowForward props

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute Feature/Ensure Progress Bar is screen reader friendly (#1674)

* Add unit size filter to backend (#1660)

* Add unit size filter to backend (#368)

* initial thoughts

* initial bedrooms filter (untested)

* Fix code style issues with Prettier

* fix typo in 'studio'

* remove custom filter handling, switch to bedrooms field on unit table

* add additional check for invalid comparisons, outside the filter handler

* use unit_type table for bedrooms, add field to unit_type table, remove toLowerCase() from filter name comparisons to allow camelCase filter names

* Fix code style issues with Prettier

* add bedrooms filter to frontend comparison map

* fix comparison type for frontend map

* fix test and migration indentation

* update changelog

* regenerate swagger

* fix tests

* try to fix more ui tests

* try to fix more ui tests

* add comment for custom filter handling

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* fix missing bedrooms build error

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1431/google translate (#1590)

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Google translate refactoring

* Fix listings service spec

* adds custom cache interceptor for language

* updates custom cache interceptor

* Add missing Headers import for listings controller

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Restructure units summary table (#1670)

* Add UnitsSummary to Listing

* remove listing service changes

* redo migration

* monthlyRent as number

* fix lint errors

* Fix code style issues with Prettier

* Hardcode the number of items in listings.e2e-spec.ts. (#1643)

Using the length of the array from seed.ts was causing flakiness if the
bloom database was not set up in the testing environment.

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute/Create listing updated UI component (#1676)

* 1621/Listing Views (#1626)

* set fallback to true for getStaticPaths so new paths can be added

* adds revalidate to staticProps

* updates for cache revalidation on the frontend

* trigger cleanup

* fixes listing bug issue

* adds additional checks for unit type and priority

* new line

* Fix code style issues with Prettier

* adds listing view

* adds other views

* adds unitsAvailable to select

* updates to pass view as query param for list and by id

* removes comment

* Update CHANGELOG.md

* updates view test

* rename spec and remove log

* removes another log

* updates partner-role migration

* updates partner-role migration

* adds --runInBand --detectOpenHandles to backend test

* adds view param to applications e2e spec test that fetches listings

* updates default view to full and fixes housing-counselors bug

* view test update

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1629/fcfs with date (#1680)

* 1629/fcfs with date

* changelog

* 1611/what to expect editable in listings management (#1681)

* 1611/what to expect editable

* fixup unit test

* changelog

* Make actions an optional prop and hide the footer when not present. (#1690)

* Make features section more robust (#1688)

* Fixes whatToExpect UI Component failing test (#1692)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Add migration (#1689)

Co-authored-by: seanmalbert <smabert@gmail.com>

* Fix code style issues with Prettier

* adds SRO to num_bedroom case

* 872/allow for unit sets to have multiple ami charts (#1678)

* Updates cache clear to use reset, instead of maintaining cache keys (#1698)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* testing build issues (#1699)

* testing build issues

* testing build issues pt 2

* Updates translations to check for values before sending to service

Co-authored-by: seanmalbert <smabert@gmail.com>

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
seanmalbert added a commit that referenced this pull request Aug 24, 2021
* 1545/lat-long draggable map (#1577)

* 1616/user roles (#1673) from 1628

* User roles for partners

* generate migration

* update client

* update seeds and policy

* migrate partners from leasing agent table

* change enum name

* Remove anonymous role

* Update authz.service.ts

* fix application view

* update changelog

* fix backend tests

* add test

* fix ui tests

Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>

* Fix code style issues with Prettier

* 1587/Updates Listing Columns and Perms so Leasing Agents can Edit (#1627)

* updates for cache revalidation on the frontend

* fixes listing bug issue

* Updates partner listings columns

* updates policy and user perms

* skips tests until #1616 is implemented

* updates to work with new user roles

* remove origin from listing service list args

* test update

* Fix code style issues with Prettier

* Split Listing form up into two main tabs (#1644)

* Add tabs to the listing form

* Fix button positions and ensure tabs always render

* Add #1644 to Changelog

* fixes warning for ArrowForward props

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute Feature/Ensure Progress Bar is screen reader friendly (#1674)

* Add unit size filter to backend (#1660)

* Add unit size filter to backend (#368)

* initial thoughts

* initial bedrooms filter (untested)

* Fix code style issues with Prettier

* fix typo in 'studio'

* remove custom filter handling, switch to bedrooms field on unit table

* add additional check for invalid comparisons, outside the filter handler

* use unit_type table for bedrooms, add field to unit_type table, remove toLowerCase() from filter name comparisons to allow camelCase filter names

* Fix code style issues with Prettier

* add bedrooms filter to frontend comparison map

* fix comparison type for frontend map

* fix test and migration indentation

* update changelog

* regenerate swagger

* fix tests

* try to fix more ui tests

* try to fix more ui tests

* add comment for custom filter handling

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* fix missing bedrooms build error

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1431/google translate (#1590)

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Google translate refactoring

* Fix listings service spec

* adds custom cache interceptor for language

* updates custom cache interceptor

* Add missing Headers import for listings controller

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Restructure units summary table (#1670)

* Add UnitsSummary to Listing

* remove listing service changes

* redo migration

* monthlyRent as number

* fix lint errors

* Fix code style issues with Prettier

* Hardcode the number of items in listings.e2e-spec.ts. (#1643)

Using the length of the array from seed.ts was causing flakiness if the
bloom database was not set up in the testing environment.

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute/Create listing updated UI component (#1676)

* 1621/Listing Views (#1626)

* set fallback to true for getStaticPaths so new paths can be added

* adds revalidate to staticProps

* updates for cache revalidation on the frontend

* trigger cleanup

* fixes listing bug issue

* adds additional checks for unit type and priority

* new line

* Fix code style issues with Prettier

* adds listing view

* adds other views

* adds unitsAvailable to select

* updates to pass view as query param for list and by id

* removes comment

* Update CHANGELOG.md

* updates view test

* rename spec and remove log

* removes another log

* updates partner-role migration

* updates partner-role migration

* adds --runInBand --detectOpenHandles to backend test

* adds view param to applications e2e spec test that fetches listings

* updates default view to full and fixes housing-counselors bug

* view test update

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1629/fcfs with date (#1680)

* 1629/fcfs with date

* changelog

* 1611/what to expect editable in listings management (#1681)

* 1611/what to expect editable

* fixup unit test

* changelog

* Make actions an optional prop and hide the footer when not present. (#1690)

* Make features section more robust (#1688)

* Fixes whatToExpect UI Component failing test (#1692)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Add migration (#1689)

Co-authored-by: seanmalbert <smabert@gmail.com>

* Fix code style issues with Prettier

* adds SRO to num_bedroom case

* 872/allow for unit sets to have multiple ami charts (#1678)

* Updates cache clear to use reset, instead of maintaining cache keys (#1698)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* testing build issues (#1699)

* testing build issues

* testing build issues pt 2

* Updates translations to check for values before sending to service

Co-authored-by: seanmalbert <smabert@gmail.com>

* 1656/lottery type without explicit date (#1682)

* Add two lines to the LeasingAgent UI component to display information about the listing management company (#1677)

* Fix code style issues with Prettier

* 1402/multiple statuses under image card (#1700)

Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* fix application routing (#1715)

* fix-applications-url

* changelog

Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
seanmalbert added a commit that referenced this pull request Aug 25, 2021
* 1545/lat-long draggable map (#1577)

* 1616/user roles (#1673) from 1628

* User roles for partners

* generate migration

* update client

* update seeds and policy

* migrate partners from leasing agent table

* change enum name

* Remove anonymous role

* Update authz.service.ts

* fix application view

* update changelog

* fix backend tests

* add test

* fix ui tests

Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>

* Fix code style issues with Prettier

* 1587/Updates Listing Columns and Perms so Leasing Agents can Edit (#1627)

* updates for cache revalidation on the frontend

* fixes listing bug issue

* Updates partner listings columns

* updates policy and user perms

* skips tests until #1616 is implemented

* updates to work with new user roles

* remove origin from listing service list args

* test update

* Fix code style issues with Prettier

* Split Listing form up into two main tabs (#1644)

* Add tabs to the listing form

* Fix button positions and ensure tabs always render

* Add #1644 to Changelog

* fixes warning for ArrowForward props

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute Feature/Ensure Progress Bar is screen reader friendly (#1674)

* Add unit size filter to backend (#1660)

* Add unit size filter to backend (#368)

* initial thoughts

* initial bedrooms filter (untested)

* Fix code style issues with Prettier

* fix typo in 'studio'

* remove custom filter handling, switch to bedrooms field on unit table

* add additional check for invalid comparisons, outside the filter handler

* use unit_type table for bedrooms, add field to unit_type table, remove toLowerCase() from filter name comparisons to allow camelCase filter names

* Fix code style issues with Prettier

* add bedrooms filter to frontend comparison map

* fix comparison type for frontend map

* fix test and migration indentation

* update changelog

* regenerate swagger

* fix tests

* try to fix more ui tests

* try to fix more ui tests

* add comment for custom filter handling

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* fix missing bedrooms build error

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1431/google translate (#1590)

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Google translate refactoring

* Fix listings service spec

* adds custom cache interceptor for language

* updates custom cache interceptor

* Add missing Headers import for listings controller

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Restructure units summary table (#1670)

* Add UnitsSummary to Listing

* remove listing service changes

* redo migration

* monthlyRent as number

* fix lint errors

* Fix code style issues with Prettier

* Hardcode the number of items in listings.e2e-spec.ts. (#1643)

Using the length of the array from seed.ts was causing flakiness if the
bloom database was not set up in the testing environment.

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute/Create listing updated UI component (#1676)

* 1621/Listing Views (#1626)

* set fallback to true for getStaticPaths so new paths can be added

* adds revalidate to staticProps

* updates for cache revalidation on the frontend

* trigger cleanup

* fixes listing bug issue

* adds additional checks for unit type and priority

* new line

* Fix code style issues with Prettier

* adds listing view

* adds other views

* adds unitsAvailable to select

* updates to pass view as query param for list and by id

* removes comment

* Update CHANGELOG.md

* updates view test

* rename spec and remove log

* removes another log

* updates partner-role migration

* updates partner-role migration

* adds --runInBand --detectOpenHandles to backend test

* adds view param to applications e2e spec test that fetches listings

* updates default view to full and fixes housing-counselors bug

* view test update

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1629/fcfs with date (#1680)

* 1629/fcfs with date

* changelog

* 1611/what to expect editable in listings management (#1681)

* 1611/what to expect editable

* fixup unit test

* changelog

* Make actions an optional prop and hide the footer when not present. (#1690)

* Make features section more robust (#1688)

* Fixes whatToExpect UI Component failing test (#1692)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Add migration (#1689)

Co-authored-by: seanmalbert <smabert@gmail.com>

* Fix code style issues with Prettier

* adds SRO to num_bedroom case

* 872/allow for unit sets to have multiple ami charts (#1678)

* Updates cache clear to use reset, instead of maintaining cache keys (#1698)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* testing build issues (#1699)

* testing build issues

* testing build issues pt 2

* Updates translations to check for values before sending to service

Co-authored-by: seanmalbert <smabert@gmail.com>

* 1656/lottery type without explicit date (#1682)

* Add two lines to the LeasingAgent UI component to display information about the listing management company (#1677)

* Fix code style issues with Prettier

* 1402/multiple statuses under image card (#1700)

Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* fix application routing (#1715)

* fix-applications-url

* changelog

* 1691/hmi translations (#1707)

* update bha-csv (#1726)

* Fix code style issues with Prettier

Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
seanmalbert added a commit that referenced this pull request Sep 8, 2021
* update master with latest (#1727)

* 1545/lat-long draggable map (#1577)

* 1616/user roles (#1673) from 1628

* User roles for partners

* generate migration

* update client

* update seeds and policy

* migrate partners from leasing agent table

* change enum name

* Remove anonymous role

* Update authz.service.ts

* fix application view

* update changelog

* fix backend tests

* add test

* fix ui tests

Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>

* Fix code style issues with Prettier

* 1587/Updates Listing Columns and Perms so Leasing Agents can Edit (#1627)

* updates for cache revalidation on the frontend

* fixes listing bug issue

* Updates partner listings columns

* updates policy and user perms

* skips tests until #1616 is implemented

* updates to work with new user roles

* remove origin from listing service list args

* test update

* Fix code style issues with Prettier

* Split Listing form up into two main tabs (#1644)

* Add tabs to the listing form

* Fix button positions and ensure tabs always render

* Add #1644 to Changelog

* fixes warning for ArrowForward props

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute Feature/Ensure Progress Bar is screen reader friendly (#1674)

* Add unit size filter to backend (#1660)

* Add unit size filter to backend (#368)

* initial thoughts

* initial bedrooms filter (untested)

* Fix code style issues with Prettier

* fix typo in 'studio'

* remove custom filter handling, switch to bedrooms field on unit table

* add additional check for invalid comparisons, outside the filter handler

* use unit_type table for bedrooms, add field to unit_type table, remove toLowerCase() from filter name comparisons to allow camelCase filter names

* Fix code style issues with Prettier

* add bedrooms filter to frontend comparison map

* fix comparison type for frontend map

* fix test and migration indentation

* update changelog

* regenerate swagger

* fix tests

* try to fix more ui tests

* try to fix more ui tests

* add comment for custom filter handling

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* fix missing bedrooms build error

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1431/google translate (#1590)

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Google translate refactoring

* Fix listings service spec

* adds custom cache interceptor for language

* updates custom cache interceptor

* Add missing Headers import for listings controller

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Restructure units summary table (#1670)

* Add UnitsSummary to Listing

* remove listing service changes

* redo migration

* monthlyRent as number

* fix lint errors

* Fix code style issues with Prettier

* Hardcode the number of items in listings.e2e-spec.ts. (#1643)

Using the length of the array from seed.ts was causing flakiness if the
bloom database was not set up in the testing environment.

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute/Create listing updated UI component (#1676)

* 1621/Listing Views (#1626)

* set fallback to true for getStaticPaths so new paths can be added

* adds revalidate to staticProps

* updates for cache revalidation on the frontend

* trigger cleanup

* fixes listing bug issue

* adds additional checks for unit type and priority

* new line

* Fix code style issues with Prettier

* adds listing view

* adds other views

* adds unitsAvailable to select

* updates to pass view as query param for list and by id

* removes comment

* Update CHANGELOG.md

* updates view test

* rename spec and remove log

* removes another log

* updates partner-role migration

* updates partner-role migration

* adds --runInBand --detectOpenHandles to backend test

* adds view param to applications e2e spec test that fetches listings

* updates default view to full and fixes housing-counselors bug

* view test update

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1629/fcfs with date (#1680)

* 1629/fcfs with date

* changelog

* 1611/what to expect editable in listings management (#1681)

* 1611/what to expect editable

* fixup unit test

* changelog

* Make actions an optional prop and hide the footer when not present. (#1690)

* Make features section more robust (#1688)

* Fixes whatToExpect UI Component failing test (#1692)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Add migration (#1689)

Co-authored-by: seanmalbert <smabert@gmail.com>

* Fix code style issues with Prettier

* adds SRO to num_bedroom case

* 872/allow for unit sets to have multiple ami charts (#1678)

* Updates cache clear to use reset, instead of maintaining cache keys (#1698)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* testing build issues (#1699)

* testing build issues

* testing build issues pt 2

* Updates translations to check for values before sending to service

Co-authored-by: seanmalbert <smabert@gmail.com>

* 1656/lottery type without explicit date (#1682)

* Add two lines to the LeasingAgent UI component to display information about the listing management company (#1677)

* Fix code style issues with Prettier

* 1402/multiple statuses under image card (#1700)

Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* fix application routing (#1715)

* fix-applications-url

* changelog

* 1691/hmi translations (#1707)

* update bha-csv (#1726)

* Fix code style issues with Prettier

Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* Flagged set perms (#1754) (#1756)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* updates permssions for flagged sets so partner role can access

* fixes/updates listing form unit and ami chart checks

* Adding email templates

* moves logo

* Fix code style issues with Prettier

* Update inlined.html

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
Co-authored-by: Jesse Arnold <jessearnold@Jesses-MacBook-Pro.local>
seanmalbert added a commit that referenced this pull request Sep 9, 2021
* 1573/remove dependencies from listings group

* changelog

* Flagged set perms (#1754)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* updates permssions for flagged sets so partner role can access

* 1651/users table (#1679)

* Add navigation item

* Create users page

* Fix undefined

* Basic list users method setup

* Generate client

* Create users table

* Update role column

* backend-swagger updates

* adds auth check to user list

* adds pagination to user list

* joins listings id, name onto user list

* Update backend-swagger.ts

* Update backend-swagger - need to rebase before merging

* Update listings column

* Join role to the user

* sets backend-swagger to upstream

* Update backend-swagger.ts

* Update backend-swagger.ts

* Update changelog

* Update changelog

* Remove todo comment

* fixes issues with backend-swagger by updating DTOs

* updates view to be optional

* final? fixes for backend-swagger

* removes roles from create and update user

* fixing flaky tests

* makes unitSummary optional and fixes more tests

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Remove AmiChart object from UnitDto (#1575)

* Remove AmiChart object from UnitDto
Add AmiChartOverrides to listing service

* Rename ListingAmiChartOverride to UnitAmiChartOverride and move override entity relation to Unit

* Add AmiChart overriding logic tests

* Fix ListingsService.retrieve view queryparam typing (incorrect autogeneration from @query("key")

* Fix autogenerated type changes in frontend sites

* Fix UserRoleDto typing

* Add /user tests for updating roles property

* Fix ui-components tests

* Update CHANGELOG.md

* Fix code style issues with Prettier

* updates DetailsUnitDrawer to fetch and use ami chart by id

* updates ui-component tests

* removes ApiQuery for view since it's now covered with ListingsRetrieveQueryParams

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* 1721/remove business logic from HouseholdSizeField

* changelog

* add guards around min and max

* fix cypress test

* 1716/remove business logic from HousingCounselor

* changelog

* cleanup

* fixup unit tests

* 1574/remove dependencies from ListingsList

* changelog

* 1762/unit availability (#1767)

* Update unit status labels

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* 1751/character limit (#1766)

* Update character limit to 600

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* 1760/add none label if applicationDueDate does not exist (#1764)

* Add none label if applicationDueDate does not exist

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* Fix code style issues with Prettier

* 1711/403 page (#1763)

* Add 403 page

* Update changelog

* Make buttonLink prop as optional

* Make button title as optional

* Remove hero button

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* 1758/update select width (#1765)

* Update cell width

* Update changelog

* Update columns

* Update select right padding

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* relocate formatIncome

* changelog

* Adds Jurisdiction to listings, users, translations (replaces countyCode) (#1776)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* adds jurisdiction relations

* cleanup after testing

* adds jurisdiction selection to listings form

* updates backend tests

* updates to ui-components

* testing cypress tests

* renamed JuriWrap to JurisdictionWrapper

* addresses feedback from review

* Adds changelog entry

* 1687/listing pagination issues (#1782)

* Refactor addFilters to allow an array of filters to be passed as input param

* Update CHANGELOG.md

* Fix addFilters typing

* Fix listing.spec.ts tests

* Generate client

* Update backend-swagger.ts

* Add qs package

* Update axios requests for public

* Update client

* Add listings pagination

* Fix code style issues with Prettier

* Update listings requests

* Fix code style issues with Prettier

* Add qs serializer

* Fix code style issues with Prettier

* Update listings fetch hook

* Change validator to string

* Update leasingAgents value

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* Fix code style issues with Prettier

* Add application types to the listing form (#1703)

* First round of adding Application Types form

* Finish building out Application Types form

* fix comments

* WIP of adding application types to listing detail

* Regenerated backend swagger

* Fix bug in Dto

* Swagger again!

* More details on the listing detail

* Use proper schema in UI components

* updates migration script to migrate application methods to paper applications

* Fix code style issues with Prettier

* updates swagger

* adds boolean fields to listings to make application methods easier

* Fix code style issues with Prettier

* pulls application method logic into own section and simplifies

* cleanup unused fields

* ensures commonDigitalApplication is set after digitalApplication change

* Fix code style issues with Prettier

* phone field updates to handle render and "as" cases

* Fix code style issues with Prettier

* rename old ApplicationTypes and rename v2

* cleans up translation warnings and adds fixes from Detroit #528

Co-authored-by: seanmalbert <smabert@gmail.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* updates adds-application-method-referral-type

* updates adds-application-method-referral-type-2

* updates adds-application-method-referral-type-3

* updates adds-application-method-referral-type-4

* updates adds-application-method-referral-type-5

* Fix code style issues with Prettier

* Dev - fixes ApplicationType dependency issue (#1800)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* fix commonDigitalApplication dependency in ApplicationTypes

* Adding email templates (#1792)

* update master with latest (#1727)

* 1545/lat-long draggable map (#1577)

* 1616/user roles (#1673) from 1628

* User roles for partners

* generate migration

* update client

* update seeds and policy

* migrate partners from leasing agent table

* change enum name

* Remove anonymous role

* Update authz.service.ts

* fix application view

* update changelog

* fix backend tests

* add test

* fix ui tests

Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>

* Fix code style issues with Prettier

* 1587/Updates Listing Columns and Perms so Leasing Agents can Edit (#1627)

* updates for cache revalidation on the frontend

* fixes listing bug issue

* Updates partner listings columns

* updates policy and user perms

* skips tests until #1616 is implemented

* updates to work with new user roles

* remove origin from listing service list args

* test update

* Fix code style issues with Prettier

* Split Listing form up into two main tabs (#1644)

* Add tabs to the listing form

* Fix button positions and ensure tabs always render

* Add #1644 to Changelog

* fixes warning for ArrowForward props

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute Feature/Ensure Progress Bar is screen reader friendly (#1674)

* Add unit size filter to backend (#1660)

* Add unit size filter to backend (#368)

* initial thoughts

* initial bedrooms filter (untested)

* Fix code style issues with Prettier

* fix typo in 'studio'

* remove custom filter handling, switch to bedrooms field on unit table

* add additional check for invalid comparisons, outside the filter handler

* use unit_type table for bedrooms, add field to unit_type table, remove toLowerCase() from filter name comparisons to allow camelCase filter names

* Fix code style issues with Prettier

* add bedrooms filter to frontend comparison map

* fix comparison type for frontend map

* fix test and migration indentation

* update changelog

* regenerate swagger

* fix tests

* try to fix more ui tests

* try to fix more ui tests

* add comment for custom filter handling

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* fix missing bedrooms build error

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1431/google translate (#1590)

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Google translate refactoring

* Fix listings service spec

* adds custom cache interceptor for language

* updates custom cache interceptor

* Add missing Headers import for listings controller

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Restructure units summary table (#1670)

* Add UnitsSummary to Listing

* remove listing service changes

* redo migration

* monthlyRent as number

* fix lint errors

* Fix code style issues with Prettier

* Hardcode the number of items in listings.e2e-spec.ts. (#1643)

Using the length of the array from seed.ts was causing flakiness if the
bloom database was not set up in the testing environment.

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute/Create listing updated UI component (#1676)

* 1621/Listing Views (#1626)

* set fallback to true for getStaticPaths so new paths can be added

* adds revalidate to staticProps

* updates for cache revalidation on the frontend

* trigger cleanup

* fixes listing bug issue

* adds additional checks for unit type and priority

* new line

* Fix code style issues with Prettier

* adds listing view

* adds other views

* adds unitsAvailable to select

* updates to pass view as query param for list and by id

* removes comment

* Update CHANGELOG.md

* updates view test

* rename spec and remove log

* removes another log

* updates partner-role migration

* updates partner-role migration

* adds --runInBand --detectOpenHandles to backend test

* adds view param to applications e2e spec test that fetches listings

* updates default view to full and fixes housing-counselors bug

* view test update

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1629/fcfs with date (#1680)

* 1629/fcfs with date

* changelog

* 1611/what to expect editable in listings management (#1681)

* 1611/what to expect editable

* fixup unit test

* changelog

* Make actions an optional prop and hide the footer when not present. (#1690)

* Make features section more robust (#1688)

* Fixes whatToExpect UI Component failing test (#1692)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Add migration (#1689)

Co-authored-by: seanmalbert <smabert@gmail.com>

* Fix code style issues with Prettier

* adds SRO to num_bedroom case

* 872/allow for unit sets to have multiple ami charts (#1678)

* Updates cache clear to use reset, instead of maintaining cache keys (#1698)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* testing build issues (#1699)

* testing build issues

* testing build issues pt 2

* Updates translations to check for values before sending to service

Co-authored-by: seanmalbert <smabert@gmail.com>

* 1656/lottery type without explicit date (#1682)

* Add two lines to the LeasingAgent UI component to display information about the listing management company (#1677)

* Fix code style issues with Prettier

* 1402/multiple statuses under image card (#1700)

Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* fix application routing (#1715)

* fix-applications-url

* changelog

* 1691/hmi translations (#1707)

* update bha-csv (#1726)

* Fix code style issues with Prettier

Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* Flagged set perms (#1754) (#1756)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* updates permssions for flagged sets so partner role can access

* fixes/updates listing form unit and ami chart checks

* Adding email templates

* moves logo

* Fix code style issues with Prettier

* Update inlined.html

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
Co-authored-by: Jesse Arnold <jessearnold@Jesses-MacBook-Pro.local>

* 1429/application type fixes (#1806)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* fix commonDigitalApplication dependency in ApplicationTypes

* fixes render issues with application types

* updates phone field control type

* update for toggling with nested watched field

* phonefield

* 1721/remove business logic from HouseholdMemberForm

* changelog

* changelog typo

* deleting member fix

* pr feedback

* Reset page to 1 on limit change (#1809)

* Fix pagination limit

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* listing slug check for property

Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>
Co-authored-by: dominikx96 <dominikx96@gmail.com>
Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Michał Plebański <michalp@airnauts.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: Jesse James Arnold <jesse.james@exygy.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
Co-authored-by: Jesse Arnold <jessearnold@Jesses-MacBook-Pro.local>
seanmalbert added a commit that referenced this pull request Oct 13, 2021
* Dev - Listing Pagination, Filtering and LM Updates (#1814)

* 1573/remove dependencies from listings group

* changelog

* Flagged set perms (#1754)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* updates permssions for flagged sets so partner role can access

* 1651/users table (#1679)

* Add navigation item

* Create users page

* Fix undefined

* Basic list users method setup

* Generate client

* Create users table

* Update role column

* backend-swagger updates

* adds auth check to user list

* adds pagination to user list

* joins listings id, name onto user list

* Update backend-swagger.ts

* Update backend-swagger - need to rebase before merging

* Update listings column

* Join role to the user

* sets backend-swagger to upstream

* Update backend-swagger.ts

* Update backend-swagger.ts

* Update changelog

* Update changelog

* Remove todo comment

* fixes issues with backend-swagger by updating DTOs

* updates view to be optional

* final? fixes for backend-swagger

* removes roles from create and update user

* fixing flaky tests

* makes unitSummary optional and fixes more tests

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Remove AmiChart object from UnitDto (#1575)

* Remove AmiChart object from UnitDto
Add AmiChartOverrides to listing service

* Rename ListingAmiChartOverride to UnitAmiChartOverride and move override entity relation to Unit

* Add AmiChart overriding logic tests

* Fix ListingsService.retrieve view queryparam typing (incorrect autogeneration from @query("key")

* Fix autogenerated type changes in frontend sites

* Fix UserRoleDto typing

* Add /user tests for updating roles property

* Fix ui-components tests

* Update CHANGELOG.md

* Fix code style issues with Prettier

* updates DetailsUnitDrawer to fetch and use ami chart by id

* updates ui-component tests

* removes ApiQuery for view since it's now covered with ListingsRetrieveQueryParams

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* 1721/remove business logic from HouseholdSizeField

* changelog

* add guards around min and max

* fix cypress test

* 1716/remove business logic from HousingCounselor

* changelog

* cleanup

* fixup unit tests

* 1574/remove dependencies from ListingsList

* changelog

* 1762/unit availability (#1767)

* Update unit status labels

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* 1751/character limit (#1766)

* Update character limit to 600

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* 1760/add none label if applicationDueDate does not exist (#1764)

* Add none label if applicationDueDate does not exist

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* Fix code style issues with Prettier

* 1711/403 page (#1763)

* Add 403 page

* Update changelog

* Make buttonLink prop as optional

* Make button title as optional

* Remove hero button

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* 1758/update select width (#1765)

* Update cell width

* Update changelog

* Update columns

* Update select right padding

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* relocate formatIncome

* changelog

* Adds Jurisdiction to listings, users, translations (replaces countyCode) (#1776)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* adds jurisdiction relations

* cleanup after testing

* adds jurisdiction selection to listings form

* updates backend tests

* updates to ui-components

* testing cypress tests

* renamed JuriWrap to JurisdictionWrapper

* addresses feedback from review

* Adds changelog entry

* 1687/listing pagination issues (#1782)

* Refactor addFilters to allow an array of filters to be passed as input param

* Update CHANGELOG.md

* Fix addFilters typing

* Fix listing.spec.ts tests

* Generate client

* Update backend-swagger.ts

* Add qs package

* Update axios requests for public

* Update client

* Add listings pagination

* Fix code style issues with Prettier

* Update listings requests

* Fix code style issues with Prettier

* Add qs serializer

* Fix code style issues with Prettier

* Update listings fetch hook

* Change validator to string

* Update leasingAgents value

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* Fix code style issues with Prettier

* Add application types to the listing form (#1703)

* First round of adding Application Types form

* Finish building out Application Types form

* fix comments

* WIP of adding application types to listing detail

* Regenerated backend swagger

* Fix bug in Dto

* Swagger again!

* More details on the listing detail

* Use proper schema in UI components

* updates migration script to migrate application methods to paper applications

* Fix code style issues with Prettier

* updates swagger

* adds boolean fields to listings to make application methods easier

* Fix code style issues with Prettier

* pulls application method logic into own section and simplifies

* cleanup unused fields

* ensures commonDigitalApplication is set after digitalApplication change

* Fix code style issues with Prettier

* phone field updates to handle render and "as" cases

* Fix code style issues with Prettier

* rename old ApplicationTypes and rename v2

* cleans up translation warnings and adds fixes from Detroit #528

Co-authored-by: seanmalbert <smabert@gmail.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* updates adds-application-method-referral-type

* updates adds-application-method-referral-type-2

* updates adds-application-method-referral-type-3

* updates adds-application-method-referral-type-4

* updates adds-application-method-referral-type-5

* Fix code style issues with Prettier

* Dev - fixes ApplicationType dependency issue (#1800)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* fix commonDigitalApplication dependency in ApplicationTypes

* Adding email templates (#1792)

* update master with latest (#1727)

* 1545/lat-long draggable map (#1577)

* 1616/user roles (#1673) from 1628

* User roles for partners

* generate migration

* update client

* update seeds and policy

* migrate partners from leasing agent table

* change enum name

* Remove anonymous role

* Update authz.service.ts

* fix application view

* update changelog

* fix backend tests

* add test

* fix ui tests

Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>

* Fix code style issues with Prettier

* 1587/Updates Listing Columns and Perms so Leasing Agents can Edit (#1627)

* updates for cache revalidation on the frontend

* fixes listing bug issue

* Updates partner listings columns

* updates policy and user perms

* skips tests until #1616 is implemented

* updates to work with new user roles

* remove origin from listing service list args

* test update

* Fix code style issues with Prettier

* Split Listing form up into two main tabs (#1644)

* Add tabs to the listing form

* Fix button positions and ensure tabs always render

* Add #1644 to Changelog

* fixes warning for ArrowForward props

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute Feature/Ensure Progress Bar is screen reader friendly (#1674)

* Add unit size filter to backend (#1660)

* Add unit size filter to backend (#368)

* initial thoughts

* initial bedrooms filter (untested)

* Fix code style issues with Prettier

* fix typo in 'studio'

* remove custom filter handling, switch to bedrooms field on unit table

* add additional check for invalid comparisons, outside the filter handler

* use unit_type table for bedrooms, add field to unit_type table, remove toLowerCase() from filter name comparisons to allow camelCase filter names

* Fix code style issues with Prettier

* add bedrooms filter to frontend comparison map

* fix comparison type for frontend map

* fix test and migration indentation

* update changelog

* regenerate swagger

* fix tests

* try to fix more ui tests

* try to fix more ui tests

* add comment for custom filter handling

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* fix missing bedrooms build error

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1431/google translate (#1590)

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Google translate refactoring

* Fix listings service spec

* adds custom cache interceptor for language

* updates custom cache interceptor

* Add missing Headers import for listings controller

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Restructure units summary table (#1670)

* Add UnitsSummary to Listing

* remove listing service changes

* redo migration

* monthlyRent as number

* fix lint errors

* Fix code style issues with Prettier

* Hardcode the number of items in listings.e2e-spec.ts. (#1643)

Using the length of the array from seed.ts was causing flakiness if the
bloom database was not set up in the testing environment.

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute/Create listing updated UI component (#1676)

* 1621/Listing Views (#1626)

* set fallback to true for getStaticPaths so new paths can be added

* adds revalidate to staticProps

* updates for cache revalidation on the frontend

* trigger cleanup

* fixes listing bug issue

* adds additional checks for unit type and priority

* new line

* Fix code style issues with Prettier

* adds listing view

* adds other views

* adds unitsAvailable to select

* updates to pass view as query param for list and by id

* removes comment

* Update CHANGELOG.md

* updates view test

* rename spec and remove log

* removes another log

* updates partner-role migration

* updates partner-role migration

* adds --runInBand --detectOpenHandles to backend test

* adds view param to applications e2e spec test that fetches listings

* updates default view to full and fixes housing-counselors bug

* view test update

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1629/fcfs with date (#1680)

* 1629/fcfs with date

* changelog

* 1611/what to expect editable in listings management (#1681)

* 1611/what to expect editable

* fixup unit test

* changelog

* Make actions an optional prop and hide the footer when not present. (#1690)

* Make features section more robust (#1688)

* Fixes whatToExpect UI Component failing test (#1692)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Add migration (#1689)

Co-authored-by: seanmalbert <smabert@gmail.com>

* Fix code style issues with Prettier

* adds SRO to num_bedroom case

* 872/allow for unit sets to have multiple ami charts (#1678)

* Updates cache clear to use reset, instead of maintaining cache keys (#1698)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* testing build issues (#1699)

* testing build issues

* testing build issues pt 2

* Updates translations to check for values before sending to service

Co-authored-by: seanmalbert <smabert@gmail.com>

* 1656/lottery type without explicit date (#1682)

* Add two lines to the LeasingAgent UI component to display information about the listing management company (#1677)

* Fix code style issues with Prettier

* 1402/multiple statuses under image card (#1700)

Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* fix application routing (#1715)

* fix-applications-url

* changelog

* 1691/hmi translations (#1707)

* update bha-csv (#1726)

* Fix code style issues with Prettier

Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* Flagged set perms (#1754) (#1756)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* updates permssions for flagged sets so partner role can access

* fixes/updates listing form unit and ami chart checks

* Adding email templates

* moves logo

* Fix code style issues with Prettier

* Update inlined.html

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
Co-authored-by: Jesse Arnold <jessearnold@Jesses-MacBook-Pro.local>

* 1429/application type fixes (#1806)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* fix commonDigitalApplication dependency in ApplicationTypes

* fixes render issues with application types

* updates phone field control type

* update for toggling with nested watched field

* phonefield

* 1721/remove business logic from HouseholdMemberForm

* changelog

* changelog typo

* deleting member fix

* pr feedback

* Reset page to 1 on limit change (#1809)

* Fix pagination limit

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* listing slug check for property

Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>
Co-authored-by: dominikx96 <dominikx96@gmail.com>
Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Michał Plebański <michalp@airnauts.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: Jesse James Arnold <jesse.james@exygy.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
Co-authored-by: Jesse Arnold <jessearnold@Jesses-MacBook-Pro.local>

* updates asset auth policy

* fixes JurisdictionWrapper to work when only one jurisdiction

* version bump to 2.0.0-pre-tailwind

* adds log to backend application _create and updates submit alert error

* Cherry pick release with Application types fixes, notification URL and getStaticProps cleanup (#1904)

* application types, staticproptypes and notification url

* updates from listingview

* backend-swagger

* fix lint issues

* fix ApplicationSection test

* fix ApplicationSection story

* adds notifications qa from 1860 (#1907)

* adds notifications qa from 1860

* adds next start to netlify command

* Update netlify.toml

* Update homepage.scss

* feat(backend): Add tokenMissing logging to reveal user id that is failing (#1945)

* Update DeployServicesHeroku.md

* chore: resolves merge conflicts from frontend

* Fix code style issues with Prettier

* fix: adds totalFlagged and removes maxLength 600 instances

* fix: removes dup unitStatusOptions from UnitForm

Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>
Co-authored-by: dominikx96 <dominikx96@gmail.com>
Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Michał Plebański <michalp@airnauts.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: Jesse James Arnold <jesse.james@exygy.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
Co-authored-by: Jesse Arnold <jessearnold@Jesses-MacBook-Pro.local>
seanmalbert pushed a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
seanmalbert added a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
* 1545/lat-long draggable map (#1577)

* 1616/user roles (bloom-housing#1673) from 1628

* User roles for partners

* generate migration

* update client

* update seeds and policy

* migrate partners from leasing agent table

* change enum name

* Remove anonymous role

* Update authz.service.ts

* fix application view

* update changelog

* fix backend tests

* add test

* fix ui tests

Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>

* Fix code style issues with Prettier

* 1587/Updates Listing Columns and Perms so Leasing Agents can Edit (#1627)

* updates for cache revalidation on the frontend

* fixes listing bug issue

* Updates partner listings columns

* updates policy and user perms

* skips tests until #1616 is implemented

* updates to work with new user roles

* remove origin from listing service list args

* test update

* Fix code style issues with Prettier

* Split Listing form up into two main tabs (#1644)

* Add tabs to the listing form

* Fix button positions and ensure tabs always render

* Add #1644 to Changelog

* fixes warning for ArrowForward props

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute Feature/Ensure Progress Bar is screen reader friendly (bloom-housing#1674)

* Add unit size filter to backend (bloom-housing#1660)

* Add unit size filter to backend (#368)

* initial thoughts

* initial bedrooms filter (untested)

* Fix code style issues with Prettier

* fix typo in 'studio'

* remove custom filter handling, switch to bedrooms field on unit table

* add additional check for invalid comparisons, outside the filter handler

* use unit_type table for bedrooms, add field to unit_type table, remove toLowerCase() from filter name comparisons to allow camelCase filter names

* Fix code style issues with Prettier

* add bedrooms filter to frontend comparison map

* fix comparison type for frontend map

* fix test and migration indentation

* update changelog

* regenerate swagger

* fix tests

* try to fix more ui tests

* try to fix more ui tests

* add comment for custom filter handling

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* fix missing bedrooms build error

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1431/google translate (#1590)

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Google translate refactoring

* Fix listings service spec

* adds custom cache interceptor for language

* updates custom cache interceptor

* Add missing Headers import for listings controller

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Restructure units summary table (bloom-housing#1670)

* Add UnitsSummary to Listing

* remove listing service changes

* redo migration

* monthlyRent as number

* fix lint errors

* Fix code style issues with Prettier

* Hardcode the number of items in listings.e2e-spec.ts. (#1643)

Using the length of the array from seed.ts was causing flakiness if the
bloom database was not set up in the testing environment.

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute/Create listing updated UI component (bloom-housing#1676)

* 1621/Listing Views (#1626)

* set fallback to true for getStaticPaths so new paths can be added

* adds revalidate to staticProps

* updates for cache revalidation on the frontend

* trigger cleanup

* fixes listing bug issue

* adds additional checks for unit type and priority

* new line

* Fix code style issues with Prettier

* adds listing view

* adds other views

* adds unitsAvailable to select

* updates to pass view as query param for list and by id

* removes comment

* Update CHANGELOG.md

* updates view test

* rename spec and remove log

* removes another log

* updates partner-role migration

* updates partner-role migration

* adds --runInBand --detectOpenHandles to backend test

* adds view param to applications e2e spec test that fetches listings

* updates default view to full and fixes housing-counselors bug

* view test update

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1629/fcfs with date (bloom-housing#1680)

* 1629/fcfs with date

* changelog

* 1611/what to expect editable in listings management (bloom-housing#1681)

* 1611/what to expect editable

* fixup unit test

* changelog

* Make actions an optional prop and hide the footer when not present. (bloom-housing#1690)

* Make features section more robust (bloom-housing#1688)

* Fixes whatToExpect UI Component failing test (bloom-housing#1692)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Add migration (bloom-housing#1689)

Co-authored-by: seanmalbert <smabert@gmail.com>

* Fix code style issues with Prettier

* adds SRO to num_bedroom case

* 872/allow for unit sets to have multiple ami charts (bloom-housing#1678)

* Updates cache clear to use reset, instead of maintaining cache keys (bloom-housing#1698)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* testing build issues (bloom-housing#1699)

* testing build issues

* testing build issues pt 2

* Updates translations to check for values before sending to service

Co-authored-by: seanmalbert <smabert@gmail.com>

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
seanmalbert added a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
* 1545/lat-long draggable map (#1577)

* 1616/user roles (bloom-housing#1673) from 1628

* User roles for partners

* generate migration

* update client

* update seeds and policy

* migrate partners from leasing agent table

* change enum name

* Remove anonymous role

* Update authz.service.ts

* fix application view

* update changelog

* fix backend tests

* add test

* fix ui tests

Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>

* Fix code style issues with Prettier

* 1587/Updates Listing Columns and Perms so Leasing Agents can Edit (#1627)

* updates for cache revalidation on the frontend

* fixes listing bug issue

* Updates partner listings columns

* updates policy and user perms

* skips tests until #1616 is implemented

* updates to work with new user roles

* remove origin from listing service list args

* test update

* Fix code style issues with Prettier

* Split Listing form up into two main tabs (#1644)

* Add tabs to the listing form

* Fix button positions and ensure tabs always render

* Add #1644 to Changelog

* fixes warning for ArrowForward props

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute Feature/Ensure Progress Bar is screen reader friendly (bloom-housing#1674)

* Add unit size filter to backend (bloom-housing#1660)

* Add unit size filter to backend (#368)

* initial thoughts

* initial bedrooms filter (untested)

* Fix code style issues with Prettier

* fix typo in 'studio'

* remove custom filter handling, switch to bedrooms field on unit table

* add additional check for invalid comparisons, outside the filter handler

* use unit_type table for bedrooms, add field to unit_type table, remove toLowerCase() from filter name comparisons to allow camelCase filter names

* Fix code style issues with Prettier

* add bedrooms filter to frontend comparison map

* fix comparison type for frontend map

* fix test and migration indentation

* update changelog

* regenerate swagger

* fix tests

* try to fix more ui tests

* try to fix more ui tests

* add comment for custom filter handling

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* fix missing bedrooms build error

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1431/google translate (#1590)

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Google translate refactoring

* Fix listings service spec

* adds custom cache interceptor for language

* updates custom cache interceptor

* Add missing Headers import for listings controller

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Restructure units summary table (bloom-housing#1670)

* Add UnitsSummary to Listing

* remove listing service changes

* redo migration

* monthlyRent as number

* fix lint errors

* Fix code style issues with Prettier

* Hardcode the number of items in listings.e2e-spec.ts. (#1643)

Using the length of the array from seed.ts was causing flakiness if the
bloom database was not set up in the testing environment.

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute/Create listing updated UI component (bloom-housing#1676)

* 1621/Listing Views (#1626)

* set fallback to true for getStaticPaths so new paths can be added

* adds revalidate to staticProps

* updates for cache revalidation on the frontend

* trigger cleanup

* fixes listing bug issue

* adds additional checks for unit type and priority

* new line

* Fix code style issues with Prettier

* adds listing view

* adds other views

* adds unitsAvailable to select

* updates to pass view as query param for list and by id

* removes comment

* Update CHANGELOG.md

* updates view test

* rename spec and remove log

* removes another log

* updates partner-role migration

* updates partner-role migration

* adds --runInBand --detectOpenHandles to backend test

* adds view param to applications e2e spec test that fetches listings

* updates default view to full and fixes housing-counselors bug

* view test update

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1629/fcfs with date (bloom-housing#1680)

* 1629/fcfs with date

* changelog

* 1611/what to expect editable in listings management (bloom-housing#1681)

* 1611/what to expect editable

* fixup unit test

* changelog

* Make actions an optional prop and hide the footer when not present. (bloom-housing#1690)

* Make features section more robust (bloom-housing#1688)

* Fixes whatToExpect UI Component failing test (bloom-housing#1692)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Add migration (bloom-housing#1689)

Co-authored-by: seanmalbert <smabert@gmail.com>

* Fix code style issues with Prettier

* adds SRO to num_bedroom case

* 872/allow for unit sets to have multiple ami charts (bloom-housing#1678)

* Updates cache clear to use reset, instead of maintaining cache keys (bloom-housing#1698)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* testing build issues (bloom-housing#1699)

* testing build issues

* testing build issues pt 2

* Updates translations to check for values before sending to service

Co-authored-by: seanmalbert <smabert@gmail.com>

* 1656/lottery type without explicit date (bloom-housing#1682)

* Add two lines to the LeasingAgent UI component to display information about the listing management company (bloom-housing#1677)

* Fix code style issues with Prettier

* 1402/multiple statuses under image card (bloom-housing#1700)

Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* fix application routing (bloom-housing#1715)

* fix-applications-url

* changelog

Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
seanmalbert added a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
* 1545/lat-long draggable map (#1577)

* 1616/user roles (bloom-housing#1673) from 1628

* User roles for partners

* generate migration

* update client

* update seeds and policy

* migrate partners from leasing agent table

* change enum name

* Remove anonymous role

* Update authz.service.ts

* fix application view

* update changelog

* fix backend tests

* add test

* fix ui tests

Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>

* Fix code style issues with Prettier

* 1587/Updates Listing Columns and Perms so Leasing Agents can Edit (#1627)

* updates for cache revalidation on the frontend

* fixes listing bug issue

* Updates partner listings columns

* updates policy and user perms

* skips tests until #1616 is implemented

* updates to work with new user roles

* remove origin from listing service list args

* test update

* Fix code style issues with Prettier

* Split Listing form up into two main tabs (#1644)

* Add tabs to the listing form

* Fix button positions and ensure tabs always render

* Add #1644 to Changelog

* fixes warning for ArrowForward props

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute Feature/Ensure Progress Bar is screen reader friendly (bloom-housing#1674)

* Add unit size filter to backend (bloom-housing#1660)

* Add unit size filter to backend (#368)

* initial thoughts

* initial bedrooms filter (untested)

* Fix code style issues with Prettier

* fix typo in 'studio'

* remove custom filter handling, switch to bedrooms field on unit table

* add additional check for invalid comparisons, outside the filter handler

* use unit_type table for bedrooms, add field to unit_type table, remove toLowerCase() from filter name comparisons to allow camelCase filter names

* Fix code style issues with Prettier

* add bedrooms filter to frontend comparison map

* fix comparison type for frontend map

* fix test and migration indentation

* update changelog

* regenerate swagger

* fix tests

* try to fix more ui tests

* try to fix more ui tests

* add comment for custom filter handling

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* fix missing bedrooms build error

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1431/google translate (#1590)

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Google translate refactoring

* Fix listings service spec

* adds custom cache interceptor for language

* updates custom cache interceptor

* Add missing Headers import for listings controller

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Restructure units summary table (bloom-housing#1670)

* Add UnitsSummary to Listing

* remove listing service changes

* redo migration

* monthlyRent as number

* fix lint errors

* Fix code style issues with Prettier

* Hardcode the number of items in listings.e2e-spec.ts. (#1643)

Using the length of the array from seed.ts was causing flakiness if the
bloom database was not set up in the testing environment.

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute/Create listing updated UI component (bloom-housing#1676)

* 1621/Listing Views (#1626)

* set fallback to true for getStaticPaths so new paths can be added

* adds revalidate to staticProps

* updates for cache revalidation on the frontend

* trigger cleanup

* fixes listing bug issue

* adds additional checks for unit type and priority

* new line

* Fix code style issues with Prettier

* adds listing view

* adds other views

* adds unitsAvailable to select

* updates to pass view as query param for list and by id

* removes comment

* Update CHANGELOG.md

* updates view test

* rename spec and remove log

* removes another log

* updates partner-role migration

* updates partner-role migration

* adds --runInBand --detectOpenHandles to backend test

* adds view param to applications e2e spec test that fetches listings

* updates default view to full and fixes housing-counselors bug

* view test update

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1629/fcfs with date (bloom-housing#1680)

* 1629/fcfs with date

* changelog

* 1611/what to expect editable in listings management (bloom-housing#1681)

* 1611/what to expect editable

* fixup unit test

* changelog

* Make actions an optional prop and hide the footer when not present. (bloom-housing#1690)

* Make features section more robust (bloom-housing#1688)

* Fixes whatToExpect UI Component failing test (bloom-housing#1692)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Add migration (bloom-housing#1689)

Co-authored-by: seanmalbert <smabert@gmail.com>

* Fix code style issues with Prettier

* adds SRO to num_bedroom case

* 872/allow for unit sets to have multiple ami charts (bloom-housing#1678)

* Updates cache clear to use reset, instead of maintaining cache keys (bloom-housing#1698)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* testing build issues (bloom-housing#1699)

* testing build issues

* testing build issues pt 2

* Updates translations to check for values before sending to service

Co-authored-by: seanmalbert <smabert@gmail.com>

* 1656/lottery type without explicit date (bloom-housing#1682)

* Add two lines to the LeasingAgent UI component to display information about the listing management company (bloom-housing#1677)

* Fix code style issues with Prettier

* 1402/multiple statuses under image card (bloom-housing#1700)

Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* fix application routing (bloom-housing#1715)

* fix-applications-url

* changelog

* 1691/hmi translations (bloom-housing#1707)

* update bha-csv (bloom-housing#1726)

* Fix code style issues with Prettier

Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
seanmalbert added a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
* update master with latest (bloom-housing#1727)

* 1545/lat-long draggable map (#1577)

* 1616/user roles (bloom-housing#1673) from 1628

* User roles for partners

* generate migration

* update client

* update seeds and policy

* migrate partners from leasing agent table

* change enum name

* Remove anonymous role

* Update authz.service.ts

* fix application view

* update changelog

* fix backend tests

* add test

* fix ui tests

Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>

* Fix code style issues with Prettier

* 1587/Updates Listing Columns and Perms so Leasing Agents can Edit (#1627)

* updates for cache revalidation on the frontend

* fixes listing bug issue

* Updates partner listings columns

* updates policy and user perms

* skips tests until #1616 is implemented

* updates to work with new user roles

* remove origin from listing service list args

* test update

* Fix code style issues with Prettier

* Split Listing form up into two main tabs (#1644)

* Add tabs to the listing form

* Fix button positions and ensure tabs always render

* Add #1644 to Changelog

* fixes warning for ArrowForward props

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute Feature/Ensure Progress Bar is screen reader friendly (bloom-housing#1674)

* Add unit size filter to backend (bloom-housing#1660)

* Add unit size filter to backend (#368)

* initial thoughts

* initial bedrooms filter (untested)

* Fix code style issues with Prettier

* fix typo in 'studio'

* remove custom filter handling, switch to bedrooms field on unit table

* add additional check for invalid comparisons, outside the filter handler

* use unit_type table for bedrooms, add field to unit_type table, remove toLowerCase() from filter name comparisons to allow camelCase filter names

* Fix code style issues with Prettier

* add bedrooms filter to frontend comparison map

* fix comparison type for frontend map

* fix test and migration indentation

* update changelog

* regenerate swagger

* fix tests

* try to fix more ui tests

* try to fix more ui tests

* add comment for custom filter handling

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* fix missing bedrooms build error

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1431/google translate (#1590)

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Google translate refactoring

* Fix listings service spec

* adds custom cache interceptor for language

* updates custom cache interceptor

* Add missing Headers import for listings controller

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Restructure units summary table (bloom-housing#1670)

* Add UnitsSummary to Listing

* remove listing service changes

* redo migration

* monthlyRent as number

* fix lint errors

* Fix code style issues with Prettier

* Hardcode the number of items in listings.e2e-spec.ts. (#1643)

Using the length of the array from seed.ts was causing flakiness if the
bloom database was not set up in the testing environment.

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute/Create listing updated UI component (bloom-housing#1676)

* 1621/Listing Views (#1626)

* set fallback to true for getStaticPaths so new paths can be added

* adds revalidate to staticProps

* updates for cache revalidation on the frontend

* trigger cleanup

* fixes listing bug issue

* adds additional checks for unit type and priority

* new line

* Fix code style issues with Prettier

* adds listing view

* adds other views

* adds unitsAvailable to select

* updates to pass view as query param for list and by id

* removes comment

* Update CHANGELOG.md

* updates view test

* rename spec and remove log

* removes another log

* updates partner-role migration

* updates partner-role migration

* adds --runInBand --detectOpenHandles to backend test

* adds view param to applications e2e spec test that fetches listings

* updates default view to full and fixes housing-counselors bug

* view test update

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1629/fcfs with date (bloom-housing#1680)

* 1629/fcfs with date

* changelog

* 1611/what to expect editable in listings management (bloom-housing#1681)

* 1611/what to expect editable

* fixup unit test

* changelog

* Make actions an optional prop and hide the footer when not present. (bloom-housing#1690)

* Make features section more robust (bloom-housing#1688)

* Fixes whatToExpect UI Component failing test (bloom-housing#1692)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Add migration (bloom-housing#1689)

Co-authored-by: seanmalbert <smabert@gmail.com>

* Fix code style issues with Prettier

* adds SRO to num_bedroom case

* 872/allow for unit sets to have multiple ami charts (bloom-housing#1678)

* Updates cache clear to use reset, instead of maintaining cache keys (bloom-housing#1698)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* testing build issues (bloom-housing#1699)

* testing build issues

* testing build issues pt 2

* Updates translations to check for values before sending to service

Co-authored-by: seanmalbert <smabert@gmail.com>

* 1656/lottery type without explicit date (bloom-housing#1682)

* Add two lines to the LeasingAgent UI component to display information about the listing management company (bloom-housing#1677)

* Fix code style issues with Prettier

* 1402/multiple statuses under image card (bloom-housing#1700)

Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* fix application routing (bloom-housing#1715)

* fix-applications-url

* changelog

* 1691/hmi translations (bloom-housing#1707)

* update bha-csv (bloom-housing#1726)

* Fix code style issues with Prettier

Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* Flagged set perms (bloom-housing#1754) (bloom-housing#1756)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* updates permssions for flagged sets so partner role can access

* fixes/updates listing form unit and ami chart checks

* Adding email templates

* moves logo

* Fix code style issues with Prettier

* Update inlined.html

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
Co-authored-by: Jesse Arnold <jessearnold@Jesses-MacBook-Pro.local>
seanmalbert added a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
* 1573/remove dependencies from listings group

* changelog

* Flagged set perms (bloom-housing#1754)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* updates permssions for flagged sets so partner role can access

* 1651/users table (bloom-housing#1679)

* Add navigation item

* Create users page

* Fix undefined

* Basic list users method setup

* Generate client

* Create users table

* Update role column

* backend-swagger updates

* adds auth check to user list

* adds pagination to user list

* joins listings id, name onto user list

* Update backend-swagger.ts

* Update backend-swagger - need to rebase before merging

* Update listings column

* Join role to the user

* sets backend-swagger to upstream

* Update backend-swagger.ts

* Update backend-swagger.ts

* Update changelog

* Update changelog

* Remove todo comment

* fixes issues with backend-swagger by updating DTOs

* updates view to be optional

* final? fixes for backend-swagger

* removes roles from create and update user

* fixing flaky tests

* makes unitSummary optional and fixes more tests

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Remove AmiChart object from UnitDto (#1575)

* Remove AmiChart object from UnitDto
Add AmiChartOverrides to listing service

* Rename ListingAmiChartOverride to UnitAmiChartOverride and move override entity relation to Unit

* Add AmiChart overriding logic tests

* Fix ListingsService.retrieve view queryparam typing (incorrect autogeneration from @query("key")

* Fix autogenerated type changes in frontend sites

* Fix UserRoleDto typing

* Add /user tests for updating roles property

* Fix ui-components tests

* Update CHANGELOG.md

* Fix code style issues with Prettier

* updates DetailsUnitDrawer to fetch and use ami chart by id

* updates ui-component tests

* removes ApiQuery for view since it's now covered with ListingsRetrieveQueryParams

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* 1721/remove business logic from HouseholdSizeField

* changelog

* add guards around min and max

* fix cypress test

* 1716/remove business logic from HousingCounselor

* changelog

* cleanup

* fixup unit tests

* 1574/remove dependencies from ListingsList

* changelog

* 1762/unit availability (bloom-housing#1767)

* Update unit status labels

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* 1751/character limit (bloom-housing#1766)

* Update character limit to 600

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* 1760/add none label if applicationDueDate does not exist (bloom-housing#1764)

* Add none label if applicationDueDate does not exist

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* Fix code style issues with Prettier

* 1711/403 page (bloom-housing#1763)

* Add 403 page

* Update changelog

* Make buttonLink prop as optional

* Make button title as optional

* Remove hero button

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* 1758/update select width (bloom-housing#1765)

* Update cell width

* Update changelog

* Update columns

* Update select right padding

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* relocate formatIncome

* changelog

* Adds Jurisdiction to listings, users, translations (replaces countyCode) (bloom-housing#1776)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* adds jurisdiction relations

* cleanup after testing

* adds jurisdiction selection to listings form

* updates backend tests

* updates to ui-components

* testing cypress tests

* renamed JuriWrap to JurisdictionWrapper

* addresses feedback from review

* Adds changelog entry

* 1687/listing pagination issues (bloom-housing#1782)

* Refactor addFilters to allow an array of filters to be passed as input param

* Update CHANGELOG.md

* Fix addFilters typing

* Fix listing.spec.ts tests

* Generate client

* Update backend-swagger.ts

* Add qs package

* Update axios requests for public

* Update client

* Add listings pagination

* Fix code style issues with Prettier

* Update listings requests

* Fix code style issues with Prettier

* Add qs serializer

* Fix code style issues with Prettier

* Update listings fetch hook

* Change validator to string

* Update leasingAgents value

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* Fix code style issues with Prettier

* Add application types to the listing form (bloom-housing#1703)

* First round of adding Application Types form

* Finish building out Application Types form

* fix comments

* WIP of adding application types to listing detail

* Regenerated backend swagger

* Fix bug in Dto

* Swagger again!

* More details on the listing detail

* Use proper schema in UI components

* updates migration script to migrate application methods to paper applications

* Fix code style issues with Prettier

* updates swagger

* adds boolean fields to listings to make application methods easier

* Fix code style issues with Prettier

* pulls application method logic into own section and simplifies

* cleanup unused fields

* ensures commonDigitalApplication is set after digitalApplication change

* Fix code style issues with Prettier

* phone field updates to handle render and "as" cases

* Fix code style issues with Prettier

* rename old ApplicationTypes and rename v2

* cleans up translation warnings and adds fixes from Detroit #528

Co-authored-by: seanmalbert <smabert@gmail.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* updates adds-application-method-referral-type

* updates adds-application-method-referral-type-2

* updates adds-application-method-referral-type-3

* updates adds-application-method-referral-type-4

* updates adds-application-method-referral-type-5

* Fix code style issues with Prettier

* Dev - fixes ApplicationType dependency issue (bloom-housing#1800)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* fix commonDigitalApplication dependency in ApplicationTypes

* Adding email templates (bloom-housing#1792)

* update master with latest (bloom-housing#1727)

* 1545/lat-long draggable map (#1577)

* 1616/user roles (bloom-housing#1673) from 1628

* User roles for partners

* generate migration

* update client

* update seeds and policy

* migrate partners from leasing agent table

* change enum name

* Remove anonymous role

* Update authz.service.ts

* fix application view

* update changelog

* fix backend tests

* add test

* fix ui tests

Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>

* Fix code style issues with Prettier

* 1587/Updates Listing Columns and Perms so Leasing Agents can Edit (#1627)

* updates for cache revalidation on the frontend

* fixes listing bug issue

* Updates partner listings columns

* updates policy and user perms

* skips tests until #1616 is implemented

* updates to work with new user roles

* remove origin from listing service list args

* test update

* Fix code style issues with Prettier

* Split Listing form up into two main tabs (#1644)

* Add tabs to the listing form

* Fix button positions and ensure tabs always render

* Add #1644 to Changelog

* fixes warning for ArrowForward props

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute Feature/Ensure Progress Bar is screen reader friendly (bloom-housing#1674)

* Add unit size filter to backend (bloom-housing#1660)

* Add unit size filter to backend (#368)

* initial thoughts

* initial bedrooms filter (untested)

* Fix code style issues with Prettier

* fix typo in 'studio'

* remove custom filter handling, switch to bedrooms field on unit table

* add additional check for invalid comparisons, outside the filter handler

* use unit_type table for bedrooms, add field to unit_type table, remove toLowerCase() from filter name comparisons to allow camelCase filter names

* Fix code style issues with Prettier

* add bedrooms filter to frontend comparison map

* fix comparison type for frontend map

* fix test and migration indentation

* update changelog

* regenerate swagger

* fix tests

* try to fix more ui tests

* try to fix more ui tests

* add comment for custom filter handling

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* fix missing bedrooms build error

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1431/google translate (#1590)

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Google translate refactoring

* Fix listings service spec

* adds custom cache interceptor for language

* updates custom cache interceptor

* Add missing Headers import for listings controller

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Restructure units summary table (bloom-housing#1670)

* Add UnitsSummary to Listing

* remove listing service changes

* redo migration

* monthlyRent as number

* fix lint errors

* Fix code style issues with Prettier

* Hardcode the number of items in listings.e2e-spec.ts. (#1643)

Using the length of the array from seed.ts was causing flakiness if the
bloom database was not set up in the testing environment.

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute/Create listing updated UI component (bloom-housing#1676)

* 1621/Listing Views (#1626)

* set fallback to true for getStaticPaths so new paths can be added

* adds revalidate to staticProps

* updates for cache revalidation on the frontend

* trigger cleanup

* fixes listing bug issue

* adds additional checks for unit type and priority

* new line

* Fix code style issues with Prettier

* adds listing view

* adds other views

* adds unitsAvailable to select

* updates to pass view as query param for list and by id

* removes comment

* Update CHANGELOG.md

* updates view test

* rename spec and remove log

* removes another log

* updates partner-role migration

* updates partner-role migration

* adds --runInBand --detectOpenHandles to backend test

* adds view param to applications e2e spec test that fetches listings

* updates default view to full and fixes housing-counselors bug

* view test update

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1629/fcfs with date (bloom-housing#1680)

* 1629/fcfs with date

* changelog

* 1611/what to expect editable in listings management (bloom-housing#1681)

* 1611/what to expect editable

* fixup unit test

* changelog

* Make actions an optional prop and hide the footer when not present. (bloom-housing#1690)

* Make features section more robust (bloom-housing#1688)

* Fixes whatToExpect UI Component failing test (bloom-housing#1692)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Add migration (bloom-housing#1689)

Co-authored-by: seanmalbert <smabert@gmail.com>

* Fix code style issues with Prettier

* adds SRO to num_bedroom case

* 872/allow for unit sets to have multiple ami charts (bloom-housing#1678)

* Updates cache clear to use reset, instead of maintaining cache keys (bloom-housing#1698)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* testing build issues (bloom-housing#1699)

* testing build issues

* testing build issues pt 2

* Updates translations to check for values before sending to service

Co-authored-by: seanmalbert <smabert@gmail.com>

* 1656/lottery type without explicit date (bloom-housing#1682)

* Add two lines to the LeasingAgent UI component to display information about the listing management company (bloom-housing#1677)

* Fix code style issues with Prettier

* 1402/multiple statuses under image card (bloom-housing#1700)

Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* fix application routing (bloom-housing#1715)

* fix-applications-url

* changelog

* 1691/hmi translations (bloom-housing#1707)

* update bha-csv (bloom-housing#1726)

* Fix code style issues with Prettier

Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* Flagged set perms (bloom-housing#1754) (bloom-housing#1756)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* updates permssions for flagged sets so partner role can access

* fixes/updates listing form unit and ami chart checks

* Adding email templates

* moves logo

* Fix code style issues with Prettier

* Update inlined.html

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
Co-authored-by: Jesse Arnold <jessearnold@Jesses-MacBook-Pro.local>

* 1429/application type fixes (bloom-housing#1806)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* fix commonDigitalApplication dependency in ApplicationTypes

* fixes render issues with application types

* updates phone field control type

* update for toggling with nested watched field

* phonefield

* 1721/remove business logic from HouseholdMemberForm

* changelog

* changelog typo

* deleting member fix

* pr feedback

* Reset page to 1 on limit change (bloom-housing#1809)

* Fix pagination limit

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* listing slug check for property

Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>
Co-authored-by: dominikx96 <dominikx96@gmail.com>
Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Michał Plebański <michalp@airnauts.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: Jesse James Arnold <jesse.james@exygy.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
Co-authored-by: Jesse Arnold <jessearnold@Jesses-MacBook-Pro.local>
seanmalbert added a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
* Dev - Listing Pagination, Filtering and LM Updates (bloom-housing#1814)

* 1573/remove dependencies from listings group

* changelog

* Flagged set perms (bloom-housing#1754)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* updates permssions for flagged sets so partner role can access

* 1651/users table (bloom-housing#1679)

* Add navigation item

* Create users page

* Fix undefined

* Basic list users method setup

* Generate client

* Create users table

* Update role column

* backend-swagger updates

* adds auth check to user list

* adds pagination to user list

* joins listings id, name onto user list

* Update backend-swagger.ts

* Update backend-swagger - need to rebase before merging

* Update listings column

* Join role to the user

* sets backend-swagger to upstream

* Update backend-swagger.ts

* Update backend-swagger.ts

* Update changelog

* Update changelog

* Remove todo comment

* fixes issues with backend-swagger by updating DTOs

* updates view to be optional

* final? fixes for backend-swagger

* removes roles from create and update user

* fixing flaky tests

* makes unitSummary optional and fixes more tests

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Remove AmiChart object from UnitDto (#1575)

* Remove AmiChart object from UnitDto
Add AmiChartOverrides to listing service

* Rename ListingAmiChartOverride to UnitAmiChartOverride and move override entity relation to Unit

* Add AmiChart overriding logic tests

* Fix ListingsService.retrieve view queryparam typing (incorrect autogeneration from @query("key")

* Fix autogenerated type changes in frontend sites

* Fix UserRoleDto typing

* Add /user tests for updating roles property

* Fix ui-components tests

* Update CHANGELOG.md

* Fix code style issues with Prettier

* updates DetailsUnitDrawer to fetch and use ami chart by id

* updates ui-component tests

* removes ApiQuery for view since it's now covered with ListingsRetrieveQueryParams

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* 1721/remove business logic from HouseholdSizeField

* changelog

* add guards around min and max

* fix cypress test

* 1716/remove business logic from HousingCounselor

* changelog

* cleanup

* fixup unit tests

* 1574/remove dependencies from ListingsList

* changelog

* 1762/unit availability (bloom-housing#1767)

* Update unit status labels

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* 1751/character limit (bloom-housing#1766)

* Update character limit to 600

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* 1760/add none label if applicationDueDate does not exist (bloom-housing#1764)

* Add none label if applicationDueDate does not exist

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* Fix code style issues with Prettier

* 1711/403 page (bloom-housing#1763)

* Add 403 page

* Update changelog

* Make buttonLink prop as optional

* Make button title as optional

* Remove hero button

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* 1758/update select width (bloom-housing#1765)

* Update cell width

* Update changelog

* Update columns

* Update select right padding

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* relocate formatIncome

* changelog

* Adds Jurisdiction to listings, users, translations (replaces countyCode) (bloom-housing#1776)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* adds jurisdiction relations

* cleanup after testing

* adds jurisdiction selection to listings form

* updates backend tests

* updates to ui-components

* testing cypress tests

* renamed JuriWrap to JurisdictionWrapper

* addresses feedback from review

* Adds changelog entry

* 1687/listing pagination issues (bloom-housing#1782)

* Refactor addFilters to allow an array of filters to be passed as input param

* Update CHANGELOG.md

* Fix addFilters typing

* Fix listing.spec.ts tests

* Generate client

* Update backend-swagger.ts

* Add qs package

* Update axios requests for public

* Update client

* Add listings pagination

* Fix code style issues with Prettier

* Update listings requests

* Fix code style issues with Prettier

* Add qs serializer

* Fix code style issues with Prettier

* Update listings fetch hook

* Change validator to string

* Update leasingAgents value

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* Fix code style issues with Prettier

* Add application types to the listing form (bloom-housing#1703)

* First round of adding Application Types form

* Finish building out Application Types form

* fix comments

* WIP of adding application types to listing detail

* Regenerated backend swagger

* Fix bug in Dto

* Swagger again!

* More details on the listing detail

* Use proper schema in UI components

* updates migration script to migrate application methods to paper applications

* Fix code style issues with Prettier

* updates swagger

* adds boolean fields to listings to make application methods easier

* Fix code style issues with Prettier

* pulls application method logic into own section and simplifies

* cleanup unused fields

* ensures commonDigitalApplication is set after digitalApplication change

* Fix code style issues with Prettier

* phone field updates to handle render and "as" cases

* Fix code style issues with Prettier

* rename old ApplicationTypes and rename v2

* cleans up translation warnings and adds fixes from Detroit #528

Co-authored-by: seanmalbert <smabert@gmail.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* updates adds-application-method-referral-type

* updates adds-application-method-referral-type-2

* updates adds-application-method-referral-type-3

* updates adds-application-method-referral-type-4

* updates adds-application-method-referral-type-5

* Fix code style issues with Prettier

* Dev - fixes ApplicationType dependency issue (bloom-housing#1800)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* fix commonDigitalApplication dependency in ApplicationTypes

* Adding email templates (bloom-housing#1792)

* update master with latest (bloom-housing#1727)

* 1545/lat-long draggable map (#1577)

* 1616/user roles (bloom-housing#1673) from 1628

* User roles for partners

* generate migration

* update client

* update seeds and policy

* migrate partners from leasing agent table

* change enum name

* Remove anonymous role

* Update authz.service.ts

* fix application view

* update changelog

* fix backend tests

* add test

* fix ui tests

Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>

* Fix code style issues with Prettier

* 1587/Updates Listing Columns and Perms so Leasing Agents can Edit (#1627)

* updates for cache revalidation on the frontend

* fixes listing bug issue

* Updates partner listings columns

* updates policy and user perms

* skips tests until #1616 is implemented

* updates to work with new user roles

* remove origin from listing service list args

* test update

* Fix code style issues with Prettier

* Split Listing form up into two main tabs (#1644)

* Add tabs to the listing form

* Fix button positions and ensure tabs always render

* Add #1644 to Changelog

* fixes warning for ArrowForward props

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute Feature/Ensure Progress Bar is screen reader friendly (bloom-housing#1674)

* Add unit size filter to backend (bloom-housing#1660)

* Add unit size filter to backend (#368)

* initial thoughts

* initial bedrooms filter (untested)

* Fix code style issues with Prettier

* fix typo in 'studio'

* remove custom filter handling, switch to bedrooms field on unit table

* add additional check for invalid comparisons, outside the filter handler

* use unit_type table for bedrooms, add field to unit_type table, remove toLowerCase() from filter name comparisons to allow camelCase filter names

* Fix code style issues with Prettier

* add bedrooms filter to frontend comparison map

* fix comparison type for frontend map

* fix test and migration indentation

* update changelog

* regenerate swagger

* fix tests

* try to fix more ui tests

* try to fix more ui tests

* add comment for custom filter handling

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* fix missing bedrooms build error

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1431/google translate (#1590)

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Initial google translate listing

* Translations for arrays

* Disable caching for GET listing endpoint

* Final tweaks to google translate

* Update change log for google translations

* Fix code style issues with Prettier

* Update CHANGELOG.md

* Minor cleanup for Google Translate

* Google translate refactoring

* Fix listings service spec

* adds custom cache interceptor for language

* updates custom cache interceptor

* Add missing Headers import for listings controller

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>

* Restructure units summary table (bloom-housing#1670)

* Add UnitsSummary to Listing

* remove listing service changes

* redo migration

* monthlyRent as number

* fix lint errors

* Fix code style issues with Prettier

* Hardcode the number of items in listings.e2e-spec.ts. (#1643)

Using the length of the array from seed.ts was causing flakiness if the
bloom database was not set up in the testing environment.

Co-authored-by: seanmalbert <smabert@gmail.com>

* Contribute/Create listing updated UI component (bloom-housing#1676)

* 1621/Listing Views (#1626)

* set fallback to true for getStaticPaths so new paths can be added

* adds revalidate to staticProps

* updates for cache revalidation on the frontend

* trigger cleanup

* fixes listing bug issue

* adds additional checks for unit type and priority

* new line

* Fix code style issues with Prettier

* adds listing view

* adds other views

* adds unitsAvailable to select

* updates to pass view as query param for list and by id

* removes comment

* Update CHANGELOG.md

* updates view test

* rename spec and remove log

* removes another log

* updates partner-role migration

* updates partner-role migration

* adds --runInBand --detectOpenHandles to backend test

* adds view param to applications e2e spec test that fetches listings

* updates default view to full and fixes housing-counselors bug

* view test update

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* 1629/fcfs with date (bloom-housing#1680)

* 1629/fcfs with date

* changelog

* 1611/what to expect editable in listings management (bloom-housing#1681)

* 1611/what to expect editable

* fixup unit test

* changelog

* Make actions an optional prop and hide the footer when not present. (bloom-housing#1690)

* Make features section more robust (bloom-housing#1688)

* Fixes whatToExpect UI Component failing test (bloom-housing#1692)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Add migration (bloom-housing#1689)

Co-authored-by: seanmalbert <smabert@gmail.com>

* Fix code style issues with Prettier

* adds SRO to num_bedroom case

* 872/allow for unit sets to have multiple ami charts (bloom-housing#1678)

* Updates cache clear to use reset, instead of maintaining cache keys (bloom-housing#1698)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* testing build issues (bloom-housing#1699)

* testing build issues

* testing build issues pt 2

* Updates translations to check for values before sending to service

Co-authored-by: seanmalbert <smabert@gmail.com>

* 1656/lottery type without explicit date (bloom-housing#1682)

* Add two lines to the LeasingAgent UI component to display information about the listing management company (bloom-housing#1677)

* Fix code style issues with Prettier

* 1402/multiple statuses under image card (bloom-housing#1700)

Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* fix application routing (bloom-housing#1715)

* fix-applications-url

* changelog

* 1691/hmi translations (bloom-housing#1707)

* update bha-csv (bloom-housing#1726)

* Fix code style issues with Prettier

Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>

* Flagged set perms (bloom-housing#1754) (bloom-housing#1756)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* updates permssions for flagged sets so partner role can access

* fixes/updates listing form unit and ami chart checks

* Adding email templates

* moves logo

* Fix code style issues with Prettier

* Update inlined.html

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
Co-authored-by: Jesse Arnold <jessearnold@Jesses-MacBook-Pro.local>

* 1429/application type fixes (bloom-housing#1806)

* force quit redis connection on app close

* updates for redis config

* adds enableShutdownHooks to main app

* Update archer-listing.ts

* Updates cache clear to use cacheManager reset, so we don't have to maintain keys

* Update units-transformations.ts

* Update CHANGELOG.md

* allows for not needing google api keys

* Update listings.controller.ts

* Update listings.e2e-spec.ts

* fix commonDigitalApplication dependency in ApplicationTypes

* fixes render issues with application types

* updates phone field control type

* update for toggling with nested watched field

* phonefield

* 1721/remove business logic from HouseholdMemberForm

* changelog

* changelog typo

* deleting member fix

* pr feedback

* Reset page to 1 on limit change (bloom-housing#1809)

* Fix pagination limit

* Update changelog

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>

* listing slug check for property

Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>
Co-authored-by: dominikx96 <dominikx96@gmail.com>
Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Michał Plebański <michalp@airnauts.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: Jesse James Arnold <jesse.james@exygy.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
Co-authored-by: Jesse Arnold <jessearnold@Jesses-MacBook-Pro.local>

* updates asset auth policy

* fixes JurisdictionWrapper to work when only one jurisdiction

* version bump to 2.0.0-pre-tailwind

* adds log to backend application _create and updates submit alert error

* Cherry pick release with Application types fixes, notification URL and getStaticProps cleanup (bloom-housing#1904)

* application types, staticproptypes and notification url

* updates from listingview

* backend-swagger

* fix lint issues

* fix ApplicationSection test

* fix ApplicationSection story

* adds notifications qa from 1860 (bloom-housing#1907)

* adds notifications qa from 1860

* adds next start to netlify command

* Update netlify.toml

* Update homepage.scss

* feat(backend): Add tokenMissing logging to reveal user id that is failing (bloom-housing#1945)

* Update DeployServicesHeroku.md

* chore: resolves merge conflicts from frontend

* Fix code style issues with Prettier

* fix: adds totalFlagged and removes maxLength 600 instances

* fix: removes dup unitStatusOptions from UnitForm

Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>
Co-authored-by: dominikx96 <dominikx96@gmail.com>
Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Michał Plebański <michalp@airnauts.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
Co-authored-by: Jesse James Arnold <jesse.james@exygy.com>
Co-authored-by: Abbie Farr <afarr@google.com>
Co-authored-by: Abbie Farr <83078310+abbiefarr@users.noreply.github.com>
Co-authored-by: pfeeny5 <82653098+pfeeny5@users.noreply.github.com>
Co-authored-by: Austin Valeske <avaleske@users.noreply.github.com>
Co-authored-by: Marcin Jędras <mjjedras@gmail.com>
Co-authored-by: Will Lin <4317058+willrlin@users.noreply.github.com>
Co-authored-by: Anders Schneider <anderseschneider@gmail.com>
Co-authored-by: Anthony Kong <anthony.kong@sfgov.org>
Co-authored-by: Jesse Arnold <jessearnold@Jesses-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants