Remove AmiChart object from UnitDto

[pbn4]

Pull Request Template

Issue

Addresses # (#1557)

• This change addresses the issue in full
• This change addresses only certain aspects of the issue
• This change is a dependency for another issue
• This change has a dependency from another issue

Description

This change removes AmiChart object from UnitDto.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Prototype/POC (not to merge)
• This change is a refactor/address technical debt
• This change requires a documentation update
• This change requires a SQL Script

How Can This Be Tested/Reviewed?

Please describe the tests that you ran to verify your changes. Provide instructions so we can review. Please also list any relevant details for your test configuration

• Desktop View
• Mobile View
• Test A
• Test B

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have reviewed the changes in a desktop view
• I have reviewed the changes in a mobile view
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have assigned reviewers
• I have updated the changelog to include a description of my changes

[netlify]

❌ Deploy Preview for jovial-davinci-1d67a0 failed.

🔨 Explore the source changes: f9d1f42

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-davinci-1d67a0/deploys/610dcd24e2a867000824c53c

[netlify]

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: 1007fbb

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/61285a719095a70007a45055

😎 Browse the preview: https://deploy-preview-1575--dev-partners-bloom.netlify.app

[netlify]

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 1007fbb

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/61285a717b4553000815d857

😎 Browse the preview: https://deploy-preview-1575--dev-storybook-bloom.netlify.app

[netlify]

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: 1007fbb

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/61285a71bfebbd00074ed6e2

😎 Browse the preview: https://deploy-preview-1575--dev-bloom.netlify.app

[pbn4]

There is a blocker to this issue:

  // TODO https://github.com/bloom-housing/bloom/issues/872
  if (amiCharts.length !== 1) {
    throw new Error(
      "Ami charts differ between units of the same listing, see: https://github.com/bloom-housing/bloom/issues/872"
    )
  }

unitsSummarized computing logic is written in a way that only uses a single AmiChart to create the summaries. For a Listing with multiple AmiCharts and a Unit level AmiChart override this has to change.

@seanmalbert @software-project

[seanmalbert]

@pbn4 ,
I know this has been sitting here for a while, but #872 is underway by @emilyjablonski , so we should be able to get these in soon together. You'll see that some changes that have come in ahead of this have caused conflicts. Can you make sure this is good to go, so we're ready when 872 drops.

[seanmalbert]

@pbn4 ,
Welcome back! With #872 in, we can get focus on getting this in. One thing that can be made more efficient with your PR are updates to the get hmi data function. See my comment here. Since you're getting the ami charts in this PR, we can update this to reference just the ami chart ID, and have findAmiValueInChart get the necessary ami chart by ID, so having a map { [ami chart id]: AMIChart } will probably be useful. Let me know if this doesn't make sense or if you have questions.

[emilyjablonski]

Have you taken a look at the build issues?

[netlify]

✔️ Deploy Preview for clever-edison-cd22c1 ready!

🔨 Explore the source changes: 1007fbb

🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/61285a71bc18da0008597d52

😎 Browse the preview: https://deploy-preview-1575--clever-edison-cd22c1.netlify.app

[seanmalbert]

This looks good, @pbn4 , thank you for all the updates. I added a hook to partners to fetch an ami chart by id and used that for the unit detail.