Rename dependencies comparator to linked_dependencies #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 42 42
Lines 1878 1878
=======================================
Hits 1804 1804
Misses 74 74
Continue to review full report at Codecov.
|
kwridan
previously approved these changes
Feb 2, 2020
Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
marciniwanicki
force-pushed
the
feature/rename-dependencies-comparator
branch
from
39e8a39
to
0dcad03
Compare
kwridan
approved these changes
Feb 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #41
Describe your changes
Renamed
DependenciesComparatortoLinkedDependenciesComparatoras the comparator does not cover differences in Build Phases > Dependencies. As a follow up we will add a newDependenciesComparatorwhich will strictly focus on "Dependencies" build phase .Testing performed