Add copy files build phase comparator #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
marciniwanicki
force-pushed
the
feature/copy-files-comparator
branch
from
b9d7047
to
1419004
Compare
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 95.01% 96.05% +1.04%
==========================================
Files 40 42 +2
Lines 1787 1878 +91
==========================================
+ Hits 1698 1804 +106
+ Misses 89 74 -15
Continue to review full report at Codecov.
|
…d phase, update docs Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
3 tasks
marciniwanicki
added a commit
to tuist/tuist
that referenced
this pull request
Jan 13, 2020
… phases (#886) ### Short description 📝 While working on bloomberg/xcdiff#40, we discovered that some of the build files are missing `RemoveHeadersOnCopy` attribute. The attribute determines if the headers should be striped from the archive, and if not set, can lead to headers leakage. The attribute is not visible in the Xcode UI, but added automatically every time a certain bundle types are added to a copy files build phase (i.e. .framework, .appex). Oddly the attribute is not added for `.xcframework`, but it's probably an Xcode issue (FB7533618). ### Solution 📦 Added "RemoveHeadersOnCopy" attribute for build files in embed precompiled frameworks, embed watch content, and embed app extensions build phases. ### Implementation 👩💻👨💻 - [x] Update TuistGenerator to add `RemoveHeadersOnCopy` - [x] Update acceptance tests - [x] Update CHANGELOG
kwridan
approved these changes
Jan 14, 2020
Comment on lines
+13
to
+16
| ### `copy_files` | ||
|
|
||
| Compares copy files build phases i.e. embed frameworks, extensions | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #17
Describe your changes
Added copy files build phase comparator which allow to find differences in "Extensions" or "Embed Frameworks" build phases. The comparator only compares common build phases (build phases with the same name in both projects). Name or order differences can be picked up by
BuildPhasesComparator.Testing performed
xcdiff -g copy_files):