Add RemoveHeadersOnCopy attribute for build files in copy files build phases #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… embed watch apps in copy files build phases
ghost
requested review from
kwridan and
pepicrft
and removed request for
a team
kwridan
approved these changes
Jan 13, 2020
marciniwanicki
deleted the
feautre/add-RemoveHeadersOnCopy-flag-if-needed
branch
|
Update: It seems that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
While working on bloomberg/xcdiff#40, we discovered that some of the build files have missing
RemoveHeadersOnCopyattribute. The attribute determines if the headers should be striped from the archive, and if not set, can lead to headers leakage. The attribute is not visible in the Xcode UI, but added automatically every time a certain bundle types are added to a copy files build phase (i.e. .framework, .appex).Oddly the attribute is not added for
.xcframework, but it's probably an Xcode issue (I will fill a radar).Solution 📦
Added "RemoveHeadersOnCopy" attribute for build files in embed precompiled frameworks, embed watch content, and embed app extensions build phases.
Implementation 👩💻👨💻
RemoveHeadersOnCopy