Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public b2nd.h includes blosc-private.h, which is not installed by CMake #579

Closed
cgohlke opened this issue Jan 24, 2024 · 2 comments
Closed

Comments

@cgohlke
Copy link

cgohlke commented Jan 24, 2024

I get the following compiler error when compiling source code that includes the public "b2nd.h" header (for example, imagecodecs/blosc2.pxd):

b2nd.h(30): fatal error C1083: Cannot open include file: 'blosc-private.h': No such file or directory
error: command 'C:\\Program Files\\Microsoft Visual Studio\\2022\\Community\\VC\\Tools\\MSVC\\14.37.32822\\bin\\HostX86\\x64\\cl.exe' failed with exit code 2

#include "blosc-private.h"

blosc2-c 2.13.0 was built with Visual Studio 2022 and CMake 3.28.1 on Windows. The relevant lines from the CMake install command are:

-- Install configuration: "Release"
-- Installing: D:/Build/_vc17-x64/include/blosc2.h
-- Installing: D:/Build/_vc17-x64/include/b2nd.h
-- Installing: D:/Build/_vc17-x64/include/blosc2/blosc2-export.h
-- Installing: D:/Build/_vc17-x64/include/blosc2/blosc2-common.h
-- Installing: D:/Build/_vc17-x64/include/blosc2/blosc2-stdio.h
-- Installing: D:/Build/_vc17-x64/include/blosc2/filters-registry.h
-- Installing: D:/Build/_vc17-x64/include/blosc2/codecs-registry.h
-- Installing: D:/Build/_vc17-x64/include/blosc2/tuners-registry.h

blosc-private.h is not installed. After manually installing the header file the compilation succeeds.

@martaiborra
Copy link
Collaborator

With the latest release (2.13.1) this should be fixed.

@cgohlke
Copy link
Author

cgohlke commented Jan 25, 2024

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants