Vc/io1 2884 improvements #37
Conversation
src/lib/SSVKeys.ts
Outdated
| } | ||
| async extractKeys(data: string, password: string): Promise<ExtractedKeys> { | ||
| const privateKey = await new EthereumKeyStore(data).getPrivateKey(password); | ||
| await bls.init(bls.BLS12_381); |
There was a problem hiding this comment.
I look inside of bls.init method and it's heavy. If we need parallel workers to be fast we should init it only once. Please implement this
There was a problem hiding this comment.
@meshin-blox please review
There was a problem hiding this comment.
@vadiminc I don't see it is initializing only once, did you commit it?
There was a problem hiding this comment.
yes i did, it ones. extractKeys always works as "entry point". just as exception is that someone will want to work with Threshold directly, on that case we have "try catch" to understand if need to init anyway in low level @meshin-blox
There was a problem hiding this comment.
If you take a look here:
https://github.com/bloxapp/ssv-keys/pull/37/files#diff-c127a9a3b0b9b65b6bb86b567f9cd4013f3f8b0bb89019301c2846b3882e7157L56
extractKeys is called inside of expressjs route, it means that each time you run this endpoint in parallel nature it will run bls.init, and inside of it it will do that heavy work each time, even more - with the same instance of bls object.
Regarding the fact that ssv-keys strictly works with only one BLS type (12_381), to initialize it only once and bring simple check:
if (!this.initialized) bls.init()
examples/server-worker/index.ts
Outdated
| const ssvKeys = new SSVKeys(SSVKeys.VERSION.V3); | ||
| const privateKey = await ssvKeys.getPrivateKeyFromKeystoreData(keystore, password) | ||
| const encryptedShares = await ssvKeys.buildShares(privateKey, operators_ids, operators_keys); | ||
| const ssvKeys = new SSVKeys(); |
There was a problem hiding this comment.
Even if you will init bls only once, you still need to extract new SSVKeys into level outside of express route
Fixes #<issue_number_goes_here>