Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix readme files #52

Merged
merged 2 commits into from
Aug 22, 2023
Merged

fix readme files #52

merged 2 commits into from
Aug 22, 2023

Conversation

vadiminc
Copy link
Contributor

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

meshin-dev
meshin-dev approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@meshin-dev meshin-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments only about dots in sentences everywhere (in code + readme).
I didn't check if text matches PRD, but assuming that yes.
Approved

README.md Outdated Show resolved Hide resolved
src/commands/actions/arguments/owner-nonce.ts Outdated Show resolved Hide resolved
src/commands/actions/arguments/owner-address.ts Show resolved Hide resolved
@vadiminc vadiminc merged commit dbd5939 into main Aug 22, 2023
6 checks passed
@vadiminc vadiminc deleted the vc/fix-readme branch August 22, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meshin-dev meshin-dev meshin-dev approved these changes

@andrew-blox andrew-blox andrew-blox approved these changes

@Tom-ssvlabs Tom-ssvlabs Tom-ssvlabs approved these changes

@Yonatank88 Yonatank88 Awaiting requested review from Yonatank88

@Or-blox Or-blox Awaiting requested review from Or-blox

@axelrod-blox axelrod-blox Awaiting requested review from axelrod-blox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vadiminc @meshin-dev @andrew-blox @Tom-ssvlabs