p2p: re-enable conn gater #1221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusKysel
force-pushed
the
enable-conn-gater
branch
from
cb6fee1
to
e57b8df
Compare
| if n.idx == nil { | ||
| return false | ||
| } | ||
| if n.idx.Limit(libp2pnetwork.DirOutbound) { |
There was a problem hiding this comment.
is this value controlled by the config in #1236 ?
There was a problem hiding this comment.
yes, by MaxPeers
MatusKysel
force-pushed
the
enable-conn-gater
branch
from
0f73b60
to
eed829d
Compare
MatheusFranco99
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It primarily aims to reintroduce the connection gater with improvements. This includes adding features like blacklisting, modifying tests for better functionality, re-enabling score reporting to peer indexers, and addressing various bugs and issues.